Fix Install in the missing-dependency modal - #489
Open
natepelzel wants to merge 1 commit into
Open
Conversation
natepelzel
marked this pull request as draft
September 4, 2026 19:34
The "Missing required dependency" modal calls download_game without enableUpdates, but the command requires it, so clicking Install fails with: invalid args `enableUpdates` for command `download_game`: command download_game missing required key enableUpdates Pass it the same way the library page does: true when installing the latest version.
natepelzel
force-pushed
the
fix/dependency-modal-enable-updates
branch
from
September 4, 2026 21:00
c0b0ee5 to
472b7e8
Compare
natepelzel
marked this pull request as ready for review
September 4, 2026 21:37
Member
|
I think this should just be a flat |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
When a game needs an emulator that isn't installed, pressing Play shows the "Missing required dependency" modal. Its Install button calls
download_gamewithoutenableUpdates, which the command requires, so the click fails with:The library page's install flow already passes
enableUpdates: isLatest. This does the same in the modal: true when the version being installed is the latest one.Reproduced with an Emulator entry linked from a game's launch command: the modal opens fine, and Install fails with the error above until this change.
Test plan