Add .gitattributes for correct line-breaks by checkout#31
Open
Tobias-B-Besemer wants to merge 1 commit intoDrizin:masterfrom
Open
Add .gitattributes for correct line-breaks by checkout#31Tobias-B-Besemer wants to merge 1 commit intoDrizin:masterfrom
Tobias-B-Besemer wants to merge 1 commit intoDrizin:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I will suggest you to add a file ".gitattributes" for correct line-breaks by checkout to your repo.
We at https://github.com/bleachbit/bleachbit started to use a file ".gitattributes" to have correct line-breaks by checkout no matter if you checkout with Windows (CRLF), or with a Unix-like system (LF).
This helps us e.g. by linting and solves some other issues that came up in the past...
For the beginning I created a simple and basic ".gitattributes" file.
In this file is e.g. defined, that NSI & NSH files from NSIS have ever a CRLF as line-break, because NSIS is a Windows installer and therefor Windows line-breaks make IMHO much sense...
After introducing ".gitattributes" we got in some trouble with NsisMultiUser.nsh and UAC.nsh.
I guess the problems come from because the files have no CRLF... (?)
And so I report now this problem upstream (by you) and want suggest you to use a ".gitattributes" for checkout in future, too.
The basic ".gitattributes" I have created is this PR. You can easily edit and improve it, or just use it as it is...
...if you use I will be really happy and thankful!