fix(domain): allow single-label hostnames without a TLD - #4972
Open
narcisonunez wants to merge 1 commit into
Open
fix(domain): allow single-label hostnames without a TLD#4972narcisonunez wants to merge 1 commit into
narcisonunez wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is this PR about?
Regression from #4729: VALID_HOSTNAME_REGEX required at least one dot, rejecting single-label hosts like "dokploy-server", the TLD is optional.
Checklist
Before submitting this PR, please make sure that:
canarybranch.Issues related (if applicable)
closes #4881
Screenshots (if applicable)
Greptile Summary
This PR restores support for valid single-label hostnames by making the dotted-label portion of the hostname regex optional.
dokploy-server,localhost, andexample.Confidence Score: 5/5
The PR appears safe to merge with no actionable defects identified.
The quantifier change narrowly permits a hostname without a dot while retaining the existing per-label character, length, and boundary restrictions, and the tests directly cover the intended regression.
Reviews (1): Last reviewed commit: "fix(domain): allow single-label hostname..." | Re-trigger Greptile