fix(notifications): send server threshold alerts through email, resend, gotify and ntfy - #4969
Open
Siumauricio wants to merge 1 commit into
Open
fix(notifications): send server threshold alerts through email, resend, gotify and ntfy#4969Siumauricio wants to merge 1 commit into
Siumauricio wants to merge 1 commit into
Conversation
…d, gotify and ntfy channels
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #3518
sendServerThresholdNotificationsfetched theemailrelation but never sent anything through it — the loop only handled discord, telegram, slack, mattermost, custom, lark, pushover and teams. Users who configured an email notification with the Server Threshold trigger enabled silently got nothing. Resend, Gotify and Ntfy had the same gap.Adds the four missing channels following the same patterns as
database-backup.ts, with a newserver-thresholdemail template.Greptile Summary
The PR completes server-threshold notification delivery for SMTP email, Resend, Gotify, and Ntfy.
Confidence Score: 5/5
The PR appears safe to merge, with no concrete changed-code failure identified.
The newly added channel relations, template properties, sender arguments, and channel-specific payloads align with the existing notification contracts and sibling dispatch implementations.
Reviews (1): Last reviewed commit: "fix(notifications): send server threshol..." | Re-trigger Greptile
Context used: