feat(backups): add optional custom name for backup files - #4964
Open
narcisonunez wants to merge 2 commits into
Open
feat(backups): add optional custom name for backup files#4964narcisonunez wants to merge 2 commits into
narcisonunez wants to merge 2 commits into
Conversation
narcisonunez
force-pushed
the
feat/backup-custom-file-name
branch
from
August 4, 2026 21:15
5485dae to
623ed06
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is this PR about?
customNamefield to backup schedules so the generated backup file can be prefixed with a user-defined name instead of only the raw ISO timestamp (closes Name custom in the BACKUP #4961).sanitizeBackupCustomName) and validate it via zod (^[a-zA-Z0-9._-]*$, max 100 chars) on both the form and the API input.keepLatestNBackupsretention pruning, which previously relied on filenames sorting lexicographically in hronological order, but this is no longer true once a custom name can be prepended. It now sorts by real S3 modification time (rclone lsf --format "tp") instead of by filename.Checklist
Before submitting this PR, please make sure that:
canarybranch.Issues related (if applicable)
closes #4961
Screenshots (if applicable)
Greptile Summary
The PR adds optional sanitized custom names to backup artifacts and changes retention pruning to sort objects by modification time rather than filename.
customNamebackup field, migration, API validation, and dashboard controls.Confidence Score: 5/5
The PR appears safe to merge.
No blocking failure remains.
Reviews (2): Last reviewed commit: "[autofix.ci] apply automated fixes" | Re-trigger Greptile
Context used: