Skip to content

feat: proper error handling replacing silent suppression (DOJ-2429)#6

Open
dbejarano820 wants to merge 1 commit intomainfrom
daniel/doj-2429-error-handling
Open

feat: proper error handling replacing silent suppression (DOJ-2429)#6
dbejarano820 wants to merge 1 commit intomainfrom
daniel/doj-2429-error-handling

Conversation

@dbejarano820
Copy link
Contributor

Summary

  • Added log_error(), json_escape(), and check_jq() helpers
  • Replaced 2>/dev/null with error capture + logging + fallback
  • Error log at ~/.code-sensei/error.log, auto-capped at 1000 lines
  • One-time jq-missing warning per session
  • All dynamic strings in JSON output use json_escape()

Test plan

  • bash -n passes on all scripts
  • Scripts still exit 0 on errors
  • Error log captures failures with timestamps
  • No silent error suppression without fallback

Closes DOJ-2429

🤖 Generated with Claude Code

Add log_error, json_escape, and check_jq helpers.
Replace 2>/dev/null with error capture and fallback.
Error log at ~/.code-sensei/error.log, capped at 1000 lines.

Closes DOJ-2429

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@dbejarano820
Copy link
Contributor Author

🤖 This PR has had no activity for 1+ days.

If it's still needed, please:

  • Resolve any conflicts
  • Address review feedback
  • Push an update

If it's no longer needed, please close it.

— Dojito (automated PR gardener)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant