Add reminders and location reminders CRUD support#234
Add reminders and location reminders CRUD support#234scottlovegrove wants to merge 3 commits intomainfrom
Conversation
Add full CRUD operations for both regular reminders (relative/absolute) and location reminders, including sync and async API methods, models, and tests. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
There was a problem hiding this comment.
This PR introduces valuable CRUD support for both regular and location reminders across the sync and async APIs. The implementation is solid, and the comprehensive test coverage is much appreciated. There are a few areas for refinement, specifically around adding the missing is_urgent field to the Reminder model, flattening input parameters rather than reusing the read-only Due response model, and ensuring test fixtures use distinct values to properly verify the item_id to task_id aliasing.
- Replace Due model input param with flat fields (due_string, due_date, due_datetime, due_lang, due_timezone) matching add_task pattern - Use distinct id/item_id values in test fixtures to properly exercise the item_id -> task_id alias Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
|
@doistbot Please re-review this PR |
lukemerrett
left a comment
There was a problem hiding this comment.
LGTM, have asked DoistBot to re-review it
|
Hi @scottlovegrove, thanks for putting this PR together to support reminders and location reminders! The overall structure and tests look solid, but I noticed a couple of potential payload issues in First, in Second, Let me know what you think! |
Summary
ReminderandLocationRemindermodels with appropriate field aliases (item_id→task_id)/reminders) and location reminders (/location_reminders) in sync and async APIsminute_offset) and absolute (viadue) typeson_enter/on_leave) with configurable radiusTest plan
ruff formatclean🤖 Generated with Claude Code