-
Notifications
You must be signed in to change notification settings - Fork 35
Add search endpoints for projects, sections and labels #210
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
32260f3 to
b592274
Compare
89ac7ab to
ca531fb
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This pull request adds search functionality for projects, sections, and labels in the Todoist API Python SDK. The changes implement three new search endpoints that allow filtering by name using a query string, complementing the existing list/get operations.
Changes:
- Added three new search methods:
search_projects,search_sections, andsearch_labels - Introduced endpoint path constants for the new search operations
- Fixed incomplete documentation for the
get_labelsmethod's limit parameter
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
todoist_api_python/_core/endpoints.py |
Added search path suffix constants for projects, sections, and labels endpoints |
todoist_api_python/api.py |
Implemented synchronous search methods for projects, sections, and labels; fixed documentation typo in get_labels |
todoist_api_python/api_async.py |
Implemented asynchronous wrappers for the search methods using the existing async pattern |
tests/test_api_projects.py |
Added comprehensive test for search_projects covering both sync and async variants |
tests/test_api_sections.py |
Added tests for search_sections with and without project filtering |
tests/test_api_labels.py |
Added comprehensive test for search_labels covering both sync and async variants |
CHANGELOG.md |
Documented the new search functionality in the Unreleased section |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
lefcha
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Everything looks good, only had a couple of minor nitpicks.
Add search_projects methods (sync + async) using the new /projects/search endpoint.
Add search_sections methods (sync + async) using the new /sections/search endpoint.
Add search_labels methods (sync + async) using the new /labels/search endpoint.
ca531fb to
4a3e0e3
Compare
Adds support for searching projects, sections, and labels.
API PRs: