Skip to content

๐Ÿ”จ Refactor: ์•Œ๋ฆผ ์ž๋™ ์ƒ์„ฑ ๋ฐ ๊ด€๋ฆฌ API ์ถ”๊ฐ€ - #178

Open
limhb708 wants to merge 8 commits into
DoDo-Project:developfrom
limhb708:feature/177
Open

limhb708 wants to merge 8 commits into
DoDo-Project:developfrom
limhb708:feature/177

Conversation

@limhb708

Copy link
Copy Markdown
Collaborator

๐Ÿ“„ ์ž‘์—… ๋‚ด์šฉ (Description)

์ด๋ฒˆ PR์—์„œ ๋ณ€๊ฒฝ๋˜๊ฑฐ๋‚˜ ์ถ”๊ฐ€๋œ ์ฃผ์š” ์ž‘์—…์„ ๊ฐ„๋‹จํžˆ ์„ค๋ช…ํ•ด์ฃผ์„ธ์š”.

  • ๊ด€๋ฆฌ์ž ์•Œ๋ฆผ ์Šค์ผ€์ค„ ์กฐํšŒ/์ทจ์†Œ API๋ฅผ ์ถ”๊ฐ€ํ–ˆ์Šต๋‹ˆ๋‹ค.
  • ๋Œ“๊ธ€ ์ž‘์„ฑ ์‹œ ๊ฒŒ์‹œ๊ธ€ ์ž‘์„ฑ์ž์—๊ฒŒ COMMENT ์•Œ๋ฆผ์ด ์ƒ์„ฑ๋˜๋„๋ก ์ˆ˜์ •ํ–ˆ์Šต๋‹ˆ๋‹ค.
  • ๊ฒŒ์‹œ๊ธ€/ํ™œ๋™ ๊ธฐ๋ก ๋ฐ˜์‘ ์ž‘์„ฑ ์‹œ REACTION ์•Œ๋ฆผ์ด ์ƒ์„ฑ๋˜๋„๋ก ์ˆ˜์ •ํ–ˆ์Šต๋‹ˆ๋‹ค.
  • COMMENT/REACTION ์•Œ๋ฆผ์˜ relatedId ๊ธฐ์ค€์„ ๋ช…ํ™•ํžˆ ์ •๋ฆฌํ–ˆ์Šต๋‹ˆ๋‹ค.

๐Ÿ”—

์ž‘์—…ํ•œ ์ด์Šˆ ๋ฒˆํ˜ธ๋ฅผ ์•„๋ž˜ ํ˜•์‹์œผ๋กœ PULL REQUEST BODY์— ์ž‘์„ฑํ•ด์ฃผ์„ธ์š”.
(PR ๋จธ์ง€ ์‹œ ํ•ด๋‹น ์ด์Šˆ๊ฐ€ ์ž๋™์œผ๋กœ ์ข…๋ฃŒ๋ฉ๋‹ˆ๋‹ค.)


โœ… ์ฒดํฌ๋ฆฌ์ŠคํŠธ (Checklist)

PR์„ ๋ณด๋‚ด๊ธฐ ์ „ ์•„๋ž˜ ํ•ญ๋ชฉ๋“ค์„ ๋ชจ๋‘ ํ™•์ธํ•ด์ฃผ์„ธ์š”.

  • PR ์ œ๋ชฉ์€ ์ปค๋ฐ‹ ์ปจ๋ฒค์…˜์„ ๋”ฐ๋ž์Šต๋‹ˆ๋‹ค.
  • ๊ด€๋ จ ์ด์Šˆ๋ฅผ ์—ฐ๊ฒฐํ–ˆ์Šต๋‹ˆ๋‹ค.
  • ์Šค์Šค๋กœ ์ฝ”๋“œ๋ฅผ ๊ฒ€ํ† ํ•˜๊ณ  ๋ถˆํ•„์š”ํ•œ ์ฝ”๋“œ๋ฅผ ์ œ๊ฑฐํ–ˆ์Šต๋‹ˆ๋‹ค.
  • ์ฝ”๋“œ ์Šคํƒ€์ผ์ด ํ”„๋กœ์ ํŠธ ๊ทœ์น™๊ณผ ์ผ์น˜ํ•ฉ๋‹ˆ๋‹ค. (Style)
  • ์ƒˆ๋กœ์šด ๊ธฐ๋Šฅ์— ๋Œ€ํ•œ ํ…Œ์ŠคํŠธ ์ฝ”๋“œ๋ฅผ ์ถ”๊ฐ€ํ–ˆ๊ฑฐ๋‚˜, ๊ธฐ์กด ํ…Œ์ŠคํŠธ๊ฐ€ ๋ชจ๋‘ ํ†ต๊ณผํ–ˆ์Šต๋‹ˆ๋‹ค. (Test)

๐Ÿ“ธ ์Šคํฌ๋ฆฐ์ƒท (Screenshots)

์ž‘์—… ๋‚ด์šฉ๊ณผ ๊ด€๋ จ๋œ ์Šคํฌ๋ฆฐ์ƒท์ด ์žˆ๋‹ค๋ฉด ์ฒจ๋ถ€ํ•ด์ฃผ์„ธ์š”. (UI ๋ณ€๊ฒฝ์ด ์žˆ๋Š” ๊ฒฝ์šฐ)

Before After

๐Ÿ’ฌ ๊ธฐํƒ€ ์‚ฌํ•ญ (Etc)

๋ฆฌ๋ทฐ์–ด์—๊ฒŒ ์ „๋‹ฌํ•˜๊ณ  ์‹ถ์€ ์ถ”๊ฐ€ ์ •๋ณด๊ฐ€ ์žˆ๋‹ค๋ฉด ์ž์œ ๋กญ๊ฒŒ ์ž‘์„ฑํ•ด์ฃผ์„ธ์š”.

limhb708 and others added 8 commits June 22, 2026 17:27
- ๊ด€๋ฆฌ์ž ์ „์šฉ ๋กœ๊ทธ์ธ API ์ถ”๊ฐ€

- ๊ด€๋ฆฌ์ž ์•Œ๋ฆผ ์Šค์ผ€์ค„ ๋“ฑ๋ก API ์ถ”๊ฐ€

- @scheduled ๊ธฐ๋ฐ˜ ์˜ˆ์•ฝ ์•Œ๋ฆผ ์‹คํ–‰ ๋กœ์ง ๊ตฌํ˜„

- ์˜ˆ์•ฝ ์•Œ๋ฆผ DB ์ €์žฅ ๋ฐ FCM ๋ฐœ์†ก ์ฒ˜๋ฆฌ ์ถ”๊ฐ€

- ์ผ๋ถ€ API ์„ฑ๊ณต ์‘๋‹ต์„ 200๊ณผ message ์‘๋‹ต์œผ๋กœ ์ •๋ฆฌ
# Conflicts:
#	src/main/java/com/dodo/backend/admin/controller/AdminController.java
#	src/main/java/com/dodo/backend/admin/dto/response/AdminResponse.java
#	src/main/java/com/dodo/backend/admin/service/AdminService.java
#	src/main/java/com/dodo/backend/admin/service/AdminServiceImpl.java
#	src/test/java/com/dodo/backend/admin/controller/AdminControllerTest.java
#	src/test/java/com/dodo/backend/admin/service/AdminServiceTest.java
- ์˜ˆ์•ฝ ์•Œ๋ฆผ ์ฒ˜๋ฆฌ ํŠธ๋žœ์žญ์…˜์„ ์Šค์ผ€์ค„ ๋‹จ์œ„๋กœ ๋ถ„๋ฆฌ

- PROCESSING ์„ ์  ํ† ํฐ์œผ๋กœ ๋‹ค์ค‘ ์„œ๋ฒ„ ์ค‘๋ณต ์‹คํ–‰ ๋ฐฉ์ง€

- FCM ๋ฐœ์†ก์„ DB ํŠธ๋žœ์žญ์…˜ ์™ธ๋ถ€๋กœ ์ด๋™

- ์•Œ๋ฆผ ๋ชฉ๋ก ์กฐํšŒ๋ฅผ Specification ๊ธฐ๋ฐ˜ ๋™์  ์ฟผ๋ฆฌ๋กœ ์ •๋ฆฌ

- ์•Œ๋ฆผ ์œ ํ˜• ํ•„ํ„ฐ ๋Œ€์†Œ๋ฌธ์ž ์™„ํ™” ๋ฐ ํŽ˜์ด์ง€ ๊ธฐ์ค€ 0-based ํ†ต์ผ
- ๊ด€๋ฆฌ์ž ์•Œ๋ฆผ ์Šค์ผ€์ค„ ์กฐํšŒ/์ทจ์†Œ API ์ถ”๊ฐ€
- ๋Œ“๊ธ€ ์ž‘์„ฑ ์‹œ ๊ฒŒ์‹œ๊ธ€ ์ž‘์„ฑ์ž์—๊ฒŒ COMMENT ์•Œ๋ฆผ ์ƒ์„ฑ
- ๊ฒŒ์‹œ๊ธ€/ํ™œ๋™ ๊ธฐ๋ก ๋ฐ˜์‘ ์ž‘์„ฑ ์‹œ REACTION ์•Œ๋ฆผ ์ƒ์„ฑ
- COMMENT/REACTION relatedId ๊ธฐ์ค€์„ ๋Œ€์ƒ ๋ฆฌ์†Œ์Šค ID๋กœ ์ •๋ฆฌ
- ์•Œ๋ฆผ ์Šค์ผ€์ค„ ๋ฐ ์ž๋™ ์•Œ๋ฆผ ์ƒ์„ฑ ํ…Œ์ŠคํŠธ ๋ณด๊ฐ•
@limhb708 limhb708 self-assigned this Sep 14, 2026
@limhb708 limhb708 added โš’๏ธ Refactor ๊ธฐ์กด ์ฝ”๋“œ ๋ฐ ์•„ํ‚คํ…์ฒ˜๋ฅผ ๊ฐœ์„  ๐Ÿฆฅ ์ž„ํ˜„๋นˆ ์ž„ํ˜„๋นˆ ํŒŒํŠธ labels Sep 14, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

โš’๏ธ Refactor ๊ธฐ์กด ์ฝ”๋“œ ๋ฐ ์•„ํ‚คํ…์ฒ˜๋ฅผ ๊ฐœ์„  ๐Ÿฆฅ ์ž„ํ˜„๋นˆ ์ž„ํ˜„๋นˆ ํŒŒํŠธ

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Refactor] ์•Œ๋ฆผ ์ž๋™ ์ƒ์„ฑ ๋ฐ ๊ด€๋ฆฌ API ์ถ”๊ฐ€

1 participant