Skip to content

RS-19211: Add code for predictive model simulator#41

Merged
Cadigal-displayr merged 15 commits into
masterfrom
cal-RS-19211-predictive-model-simulator
May 13, 2026
Merged

RS-19211: Add code for predictive model simulator#41
Cadigal-displayr merged 15 commits into
masterfrom
cal-RS-19211-predictive-model-simulator

Conversation

@Cadigal-displayr
Copy link
Copy Markdown
Contributor

@Cadigal-displayr Cadigal-displayr commented Apr 16, 2026

Moves the predictive model simulator code from https://wiki.q-researchsoftware.com/index.php?title=QScript_Functions_for_Model_Simulator&action=edit&oldid=70670 to this library so it can be better tested, and make the QScript code simpler (as the QScript can now just call these library functions).

  1. Autoformats R/machinelearning.R and tests/testthat/test-machinelearning.R with VS code's automatic R formatting settings
  2. Adds the simulator code
  3. Adds tests for the simulator to tests/testthat/test-machinelearningsimulator.R, replacing our Displayr and Q end-to-end tests of the feature

CI is broken from existing issues not related to my changes, and doesn't run tests, so I can't confirm that the tests pass.
However, when I run the tests inside an RItem in Displayr, they all pass, which makes me confident enough to merge this PR.

@Cadigal-displayr Cadigal-displayr force-pushed the cal-RS-19211-predictive-model-simulator branch from ee3bc22 to b3d52a2 Compare April 23, 2026 05:51
Comment thread R/machinelearning.R
Comment thread R/machinelearning.R
Comment thread R/machinelearning.R
Comment thread R/machinelearning.R
Comment thread R/machinelearning.R
Comment thread R/machinelearning.R
Comment thread R/machinelearning.R
Comment thread R/machinelearning.R
Comment thread R/machinelearning.R
Copy link
Copy Markdown
Contributor

@jrwishart jrwishart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Cadigal-displayr Cadigal-displayr merged commit 2562bc8 into master May 13, 2026
0 of 2 checks passed
@Cadigal-displayr Cadigal-displayr deleted the cal-RS-19211-predictive-model-simulator branch May 13, 2026 07:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants