Remove narrowing conversion to satisfy verifier#5
Merged
DispatchCode merged 8 commits intoDispatchCode:mainfrom Mar 5, 2026
Merged
Remove narrowing conversion to satisfy verifier#5DispatchCode merged 8 commits intoDispatchCode:mainfrom
DispatchCode merged 8 commits intoDispatchCode:mainfrom
Conversation
Pull request creation failed. Validation failed: must be a collaborator
The BPF verifier deals poorly with narrowing conversions u32 -> u64, which are implemented by clang as (r <<= 32; r >>= 32;). This breaks register identities and hence bounds checks on "identical" registers.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is actually quite interesting: narrowing u64 -> u32 confuses the verifier: