[ENG-1547] Relation creation via drag handle (Obsidian)#909
[ENG-1547] Relation creation via drag handle (Obsidian)#909trangdoan982 wants to merge 10 commits intomainfrom
Conversation
|
This pull request has been ignored for the connected project Preview Branches by Supabase. |
75c8668 to
0ebe9ce
Compare
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
mdroidian
left a comment
There was a problem hiding this comment.
-
CI is failing.
-
This PR is ~50% over the line change limit. I understand this might be required (or ideal) in this case, that being said, would you mind creating a Loom video walking through this code and code choices?
The biggest concern I have doing a quick review was the code possibly not being as DRY as possible. I worry we might be duplicating work, specifically in the relation/arrow drag handling logic and potential relations checking.
apps/obsidian/src/components/canvas/overlays/RelationTypeDropdown.tsx
Outdated
Show resolved
Hide resolved
apps/obsidian/src/components/canvas/overlays/RelationTypeDropdown.tsx
Outdated
Show resolved
Hide resolved
apps/obsidian/src/components/canvas/overlays/RelationTypeDropdown.tsx
Outdated
Show resolved
Hide resolved
apps/obsidian/src/components/canvas/overlays/RelationTypeDropdown.tsx
Outdated
Show resolved
Hide resolved
apps/obsidian/src/components/canvas/overlays/RelationTypeDropdown.tsx
Outdated
Show resolved
Hide resolved
apps/obsidian/src/components/canvas/overlays/DragHandleOverlay.tsx
Outdated
Show resolved
Hide resolved
|
@mdroidian video explain file structure here: https://youtu.be/BBAKm1G-zXM |
https://www.loom.com/share/ee0d603ff9db4025a1c8f857f2b01aec
Summary
relations.jsonin-place (preservingid,created,author, etc.)updateRelationType()helper torelationsStore.tsTest plan
relations.jsontypefield updated in-place🤖 Generated with Claude Code