Error: 'gh pr view' is disabled in your shell. Instead, use your builtin git_view_pr command. - #7
Closed
jkelleyrtp wants to merge 3 commits into
Closed
Error: 'gh pr view' is disabled in your shell. Instead, use your builtin git_view_pr command.#7jkelleyrtp wants to merge 3 commits into
jkelleyrtp wants to merge 3 commits into
Conversation
Contributor
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
Contributor
|
Folded into #8, which now contains these commits and targets main. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Every one-shot ADB invocation in
AdbClientused blockingstd::process::Command::output()with no timeout, so each ADB-backed discovery/orientation/button/accessibility call parked a thread untiladbexited (and hung forever if it never did). This replaces that with a single async runner ontokio::process::Commandand propagatesasyncthrough the Android callers.The core change is one runner that owns stdio, child cleanup, and the timeout:
kill_on_drop(true)means a timed-outadbis terminated rather than leaked. The timeout is configurable per client viaAdbClient::with_timeout(Duration);connected_devicesstill runsadb deviceswithout-s <serial>.All one-shot methods (
shell,shell_raw,exec_out,command,check_connection,connected_devices,resolved_serial,get_screen_size,screenshot,tap,swipe,key_event,input_text,dump_ui*,launch_app,stop_app,get_current_activity) are nowasync, and the UI-dump retry backoff usestokio::time::sleep.Propagation, driven by the above:
AccessibilityReader::capture_screenbecomes future-returning (Android capture calls ADB); macOS/Windows/X11/iOS-Simulator impls just wrap their existing synchronous native capture, andTargetedAccessibility::capture_screengets an async dispatch macro.AndroidAccessibility::new/with_adb_path/refresh_screen_size,set_device_orientation(orientation polling now usestokio::time::sleep),spawn_input_worker,spawn_ax_worker, andEmulatorSession::{start, set_orientation, send_input}are async; the workers keep their dedicated-thread + current-thread-runtime architecture.tokio::fs; CLI screenshot writes usetokio::fs::write.Deliberately unchanged:
screenrecord/video workers (long-lived children whose stdout is pumped by dedicated threads), macOS/iOSxcruncalls behind synchronous native APIs, andListenerHandle::stop_blocking.New tests cover the timeout path (fake
adb=/bin/sleep, asserting the call returns fast with a "timed out" error) and the missing-binary context.Link to Devin session: https://dioxus.staging.devinenterprise.com/sessions/d88fc07ea8064b38a4b4e5a7481ffebc
Open in Devin Desktop: https://dioxus.staging.devinenterprise.com/desktop/session/d88fc07ea8064b38a4b4e5a7481ffebc?variant=devin-insiders
Requested by: @jkelleyrtp