Drive simulator fill captures from a strict GCD timer on a worker queue - #10
Merged
Conversation
Contributor
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Puts the simulator fill cadence on a strict libdispatch timer instead of a sleeping thread, because relative waits (
nanosleep/pthread_cond_timedwait) get coalesced to ~100 ms on virtualised hosts, capping the thread-driven fill at ~12 fps.workerqueue (QoS user-interactive) does the actual capture work. SimulatorKit callbacks now calltrigger(force)— a cheap coalescing enqueue (pending/pending_forceatomics) — instead of runningcaptureinline on the callback queue, which the render server blocks on.start_fill_timercreates aDISPATCH_TIMER_STRICTsource on the worker queue via rawdispatch_source_*FFI (dispatch2 0.3 has no safe timer-source wrapper). Handler firescapture(true)only whenlast_capture.elapsed() + FILL_SLACK >= tick_interval, with 1.5 ms slack so timer jitter doesn't beat a 60 Hz fill down to 30 Hz.stop()cancels/releases the timer and drains the worker withexec_syncbefore releasing registrations.macOS-only code path (
packages/accessibility-ios-sys/src/macos/framebuffer.rs); verifiedcargo fmt --checkandcargo check --workspaceon Linux, macOS compile relies on CI.Link to Devin session: https://dioxus.staging.devinenterprise.com/sessions/e327e80d7dee497288adbc3cdc479ac7
Open in Devin Desktop: https://dioxus.staging.devinenterprise.com/desktop/session/e327e80d7dee497288adbc3cdc479ac7?variant=devin-insiders
Requested by: @jkelleyrtp