Small Additions for Entangled#511
Open
Immodial wants to merge 7 commits into
Open
Conversation
…icking' into 1.21.1
Previously Helmets enchanted like Leggings, Leggings enchanted like Boots, and Boots enchanted like Helmets! Not completely sure I got all code references
This replaces the "Locator" parameter, which isn't really a problem since `/execute at` offers the same functionality
Updated Enchantable tags but not actual Armor tags
Now large modpacks don't need to port every single death message, or if you are frequently sent to Limbo have the option of showing more familiar ones
Collaborator
|
Liminal LIbrary for now can be compiled locally and added maven local. If you want to take a jab at that. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
/pocketcommand now has atargetinstead of alocator, which refers to an entity to send to the pocketexecute at <locator> run pocket ...genericDeathMessages, which instead of prependinglimbo.it appends another translatable componentlimbo.death.genericFrom my testing none of these changes introduce new issues, but I'd encourage looking over my code anyways (it's not a lot) since you're definitely more familiar.
P.S. to Waterpicker: Sorry for putting more work on your plate! I didn't have access to LiminalLib so I had to make this before those commits. Integrating this stuff isn't urgent though, since I'm unfortunately probably going to have a long break where I can't work on Entangled