Feature/async profile tabs - #2433
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 6aa7c9b1f5
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| } catch (_: Exception) { | ||
| null | ||
| } |
There was a problem hiding this comment.
When this duplicate userById request transiently fails or returns an unusable body, the exception is converted to null, so both capability-dependent tabs are omitted and profileTabs still completes successfully. The tabs flow is only rerun when accountServiceFlow emits a different service/account, so retrying the separately loaded profile header does not restore the tabs; notably, this also removes the previously unconditional Highlights tab for the lifetime of the screen. Propagate a retryable error or retain a fallback tab set instead of treating lookup failure as negative capability metadata.
Useful? React with 👍 / 👎.
1 participant
No description provided.