Add an option to allow retun value of bindActionCreators call #57
Conversation
DianaSuvorova
left a comment
DianaSuvorova
left a comment
There was a problem hiding this comment.
Thank you for your PR @dentuzhik !
Please add few more test cases. Otherwise LGTM 👍
| @@ -0,0 +1,16 @@ | |||
| # EditorConfig helps developers define and maintain consistent | |||
| }); | ||
|
|
||
| ruleTester.run('mapDispatchToProps-returns-object-allowReturnBindFn', rule, { | ||
| valid: [ |
There was a problem hiding this comment.
Thank you so much for this. Would you please add some more negative cases.
For example when the option is set to true but name of the function is not bindActionCreators and when the option is set to false.
| @@ -0,0 +1,16 @@ | |||
| # EditorConfig helps developers define and maintain consistent | |||
There was a problem hiding this comment.
you can add https://npmjs.com/eccheck to CI to verify this, so it doesn't deviate
There was a problem hiding this comment.
Sorry, link above triggers 404 for me, is it some private package?
There was a problem hiding this comment.
oops sorry, https://www.npmjs.com/package/eclint :-)
specifically, eclint check $(git ls-files), added in a prelint or postlint script.
There was a problem hiding this comment.
That's quite a nice package, have not been aware of this, thanks!
I will play around and see if I can add it in the same PR
|
is this still in consideration? |
4 participants
Added a new option
allowReturnBindFnwhich does not fail thereact-redux/mapDispatchToProps-returns-objectif result ofmapmapDispatchToPropsis a proxy-call tobindActionCreatorsFor now we are using it in our fork, but considering some other issues in this repo, it might be a good addition.
Fixes #30