ref: Implement BobParser - #275
Open
adedamola-sode wants to merge 8 commits into
Open
adedamola-sode wants to merge 8 commits into
adedamola-sode wants to merge 8 commits into
Conversation
adedamola-sode
changed the title
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #275 +/- ##
==========================================
+ Coverage 96.55% 96.67% +0.12%
==========================================
Files 17 18 +1
Lines 1075 1144 +69
==========================================
+ Hits 1038 1106 +68
- Misses 37 38 +1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
adedamola-sode
marked this pull request as ready for review
October 1, 2026 10:43
adedamola-sode
force-pushed
the
ref/autofill-bob-parser
branch
from
October 1, 2026 10:43
3035678 to
d252295
Compare
OCopping
reviewed
Oct 2, 2026
| def _read_bob(self, path: Path): | ||
| tree, widgets = read_bob(path) | ||
| return tree.getroot(), widgets | ||
| tree, widget, _ = read_bob(path) |
Collaborator
There was a problem hiding this comment.
Suggested change
| tree, widget, _ = read_bob(path) | |
| tree, widgets, _ = read_bob(path) |
I assume this variable was changed accidentally
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The current logic in main is to use the techui.yaml file to find the beamline parameters such as the location, description, remote opis files, this first commit changes things so it's fetched from the index.bob itself via macros defined in the first layer of the synoptic file (index.bob). This adds: