Make thumbnail for lamella evaluation images - #898
Merged
Merged
Conversation
…e being registered
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #898 +/- ##
==========================================
+ Coverage 55.08% 55.11% +0.03%
==========================================
Files 103 103
Lines 11532 11550 +18
Branches 1530 1531 +1
==========================================
+ Hits 6352 6366 +14
- Misses 4838 4841 +3
- Partials 342 343 +1 🚀 New features to boost your workflow:
|
tieneupin
marked this pull request as ready for review
September 23, 2026 15:29
stephen-riggs
approved these changes
Sep 23, 2026
stephen-riggs
left a comment
Contributor
There was a problem hiding this comment.
Looks fine. It relies heavily on the file naming being in the expected form, but I think that should be ok.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Another scoped PR to extend the lamella image registration workflow. Adds the logic needed to save a thumbnail image of the incoming lamella image to the path
"{visit_dir}/processed/grid_{slot_number}/lamella_evaluation_images/lamella_{lamella_number}_{timestamp}_{step_name}.png".The main
runtest for this workflow has also been overhauled so that it is run using the test database session we have set up, to verify that database inserts are correct. This will be heavily made use of as the workflow is further extended and more database inserts and calls are added.Additionally, minor optimisations were made to the atlas registration workflow to improve readability and memory management when opening images.