test: Use single thread for tests when passing options - #1631
Open
tpoliaw wants to merge 1 commit into
Open
Conversation
If specifying limited tests via options such as `-k specific_test` or only running previous failures with `--lf`, the overhead of creating additional workers and gathering results can be longer than the time saved by running tests in parallel. Leaving the multi-thread options as default means running `just unit` still runs the whole suite as quickly as it can.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1631 +/- ##
=======================================
Coverage 95.96% 95.96%
=======================================
Files 45 45
Lines 3323 3323
=======================================
Hits 3189 3189
Misses 134 134 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If specifying limited tests via options such as
-k specific_testoronly running previous failures with
--lf, the overhead of creatingadditional workers and gathering results can be longer than the time
saved by running tests in parallel.
Leaving the multi-thread options as default means running
just unitstill runs the whole suite as quickly as it can.