Nl/add ptypy i08 param config - #209
Conversation
yousefmoazzam
left a comment
yousefmoazzam
left a comment
There was a problem hiding this comment.
Thanks for this!
Possibly one minor thing to change, and then a comment on something for us to keep in mind and address soon.
| <TextField | ||
| error={id.length === 0} | ||
| label="Scan Number" | ||
| value={id} | ||
| onChange={(e) => setId(e.target.value)} | ||
| size="small" | ||
| /> |
There was a problem hiding this comment.
Ideally, there wouldn't be a scan number input in the parameter configuration component and we'd use the scan selector component's scan ID.
However, I see that the current state of the ParameterConfiguration component is such that it assumes the input is given as a filepath to the input data (which is an artifact of the httomo templates that this was initially developed for), whereas the ptypy workflow template takes a scan ID as input and constructs the filepath within the workflow itself.
So for now there's no need to do anything, but we should thing about how to deal with this soon, as it connects to making all imaging workflow templates have a common interface in the sense of a common set of parameters that can be assumed by a web GUI wanting to run workflows from them.
yousefmoazzam
left a comment
yousefmoazzam
left a comment
There was a problem hiding this comment.
Looks good, thanks!
2 participants
Add a parameter configuration component for the ptypy-i08-1-from-config workflow