Skip to content

Fix incorrect setting of "auto" rotation angles param value #207

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
yousefmoazzam merged 1 commit into from
Sep 30, 2026
Merged

Fix incorrect setting of "auto" rotation angles param value #207

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions frontend/tomography/src/components/loader/Loader.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,20 +38,20 @@ const Loader: React.FC = () => {
const [autoToggles, setAutoToggles] = useState({
dataPath: parameters.data_path === "auto",
imagePath: parameters.image_key_path === "auto",
rotationAnglePath: parameters.rotation_angles?.data_path === "auto",
rotationAnglePath: parameters.rotation_angles === "auto",
});

// Effect to sync autoToggles if parameters change from elsewhere (e.g. context reset)
useEffect(() => {
setAutoToggles({
dataPath: parameters.data_path === "auto",
imagePath: parameters.image_key_path === "auto",
rotationAnglePath: parameters.rotation_angles?.data_path === "auto",
rotationAnglePath: parameters.rotation_angles === "auto",
});
}, [
parameters.data_path,
parameters.image_key_path,
parameters.rotation_angles?.data_path,
parameters.rotation_angles,
]);

const handleModeChange = (
Expand Down
21 changes: 12 additions & 9 deletions frontend/tomography/src/contexts/LoaderContext.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,14 +12,17 @@ export interface PreviewType {
interface ParametersType {
data_path: string | null; // Allow null
image_key_path?: string | null; // Allow null
rotation_angles: {
data_path?: string | "auto" | null; // Allow null and 'auto'
user_defined?: {
start_angle: number;
stop_angle: number;
angles_total: number;
};
};
rotation_angles:
| {
data_path?: string;
user_defined?: {
start_angle: number;
stop_angle: number;
angles_total: number;
};
}
| "auto"
| null;
darks?: {
file: string;
data_path: string;
Expand Down Expand Up @@ -76,7 +79,7 @@ export const LoaderProvider: React.FC<{ children: ReactNode }> = ({
const setRotationAnglesDataPath = (path: string) => {
setParameters((prev) => ({
...prev,
rotation_angles: { data_path: path },
rotation_angles: path === "auto" ? "auto" : { data_path: path },
}));
};

Expand Down
Loading