updating log compoment from a stack of bottons to a drop down menu - #197
Merged
Merged
Conversation
…his should prevent overflow of the buttons. dynamic issues have been minimised but this has made the component unintuitive, as displays no log selected regardless of whether a log exisits
NatLeung96
previously requested changes
Sep 29, 2026
yousefmoazzam
left a comment
yousefmoazzam
left a comment
Collaborator
There was a problem hiding this comment.
Cool, works for me locally!
A few questions regarding some tidying up that may or may not be possible.
| </FormControl> | ||
| </Box> | ||
| <Button | ||
| key={"something"} |
Collaborator
There was a problem hiding this comment.
This key prop looks like it may be unnecessary; if so, can it be removed please?
yousefmoazzam
approved these changes
Sep 30, 2026
yousefmoazzam
left a comment
yousefmoazzam
left a comment
Collaborator
There was a problem hiding this comment.
Looks nice, just need to resolve the conflict and this is good to merge.
yousefmoazzam
approved these changes
Sep 30, 2026
yousefmoazzam
dismissed
NatLeung96’s stale review
September 30, 2026 15:26
The most important suggestions have been resolved.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This should prevent overflow of the buttons. dynamic issues have been minimised but this has made the component unintuitive, as displays no log selected regardless of whether a log exists. The log component now better covers Failed jobs as well as successful jobs. see the example below.