Skip to content

Add collapsible sections for unified page - #180

Merged
jessicavers merged 2 commits into
mainfrom
collapsible-sections
Sep 30, 2026
Merged

jessicavers merged 2 commits into
mainfrom
collapsible-sections

Conversation

@jessicavers

Copy link
Copy Markdown
Collaborator

No description provided.

@yousefmoazzam yousefmoazzam left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is nice to have, thanks!

The only thing I'd like to be addressed is the plot component's artifact dropdown is seemingly now squished. All other component's content seem to be unchanged when moved to be inside an accordion, but this one has some issues, please see the attached screenshot and check if this is what you also see. If so, that'd be great to fix before merging.

Image

@jessicavers

Copy link
Copy Markdown
Collaborator Author

Thank you for noticing that part which I missed. I found a way to expand that by altering the ArifactSelector itself. Is that suitable?

ArtifactSelector

@yousefmoazzam

Copy link
Copy Markdown
Collaborator

Thank you for noticing that part which I missed. I found a way to expand that by altering the ArifactSelector itself. Is that suitable?

ArtifactSelector

Yep, that's reasonable to fix this by editing the artifact selector component, thanks.

# Conflicts:
#	frontend/unified/src/App.tsx
# Conflicts:
#	frontend/unified/src/components/Plot/ArtifactSelector.tsx

@yousefmoazzam yousefmoazzam left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for resolving the conflicts!

@jessicavers
jessicavers merged commit 4f3c35f into main Sep 30, 2026
1 check passed
@jessicavers

Copy link
Copy Markdown
Collaborator Author

Thank you for reviewing :)

@jessicavers
jessicavers deleted the collapsible-sections branch September 30, 2026 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants