Skip to content

Remove unused options parameter from EpicsCAIOC#322

Merged
GDYendell merged 1 commit intomainfrom
314-remove_unused_options
Feb 17, 2026
Merged

Remove unused options parameter from EpicsCAIOC#322
GDYendell merged 1 commit intomainfrom
314-remove_unused_options

Conversation

@JamesOHeaDLS
Copy link
Contributor

@JamesOHeaDLS JamesOHeaDLS commented Feb 17, 2026

Addresses issue #314 - removed the unused options parameter from EpicsCAIOC

Summary by CodeRabbit

  • Chores
    • Simplified internal configuration handling by removing legacy option parameters from core transport initialization.

@JamesOHeaDLS JamesOHeaDLS self-assigned this Feb 17, 2026
@coderabbitai
Copy link

coderabbitai bot commented Feb 17, 2026

No actionable comments were generated in the recent review. 🎉


📝 Walkthrough

Walkthrough

The pull request removes the epicsca parameter from the EpicsCAIOC constructor and eliminates related EpicsIOCOptions handling. The corresponding call site in EpicsCATransport is updated to match the simplified constructor signature.

Changes

Cohort / File(s) Summary
EpicsCAIOC Constructor Simplification
src/fastcs/transports/epics/ca/ioc.py
Removed the epicsca parameter from __init__, eliminated EpicsIOCOptions import, and removed _options attribute initialization.
EpicsCATransport Call Site Update
src/fastcs/transports/epics/ca/transport.py
Updated EpicsCAIOC instantiation in connect method to pass only pv_prefix and controller_api arguments.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~5 minutes

Poem

🐰 A hop and a skip, we cleaned up the code,
Parameter gone from the IOC road,
Simpler signatures, cleaner and bright,
Two files aligned—everything's right! ✨

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (2 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately describes the main change: removing the unused options parameter from EpicsCAIOC, which is reflected in the file changes.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch 314-remove_unused_options

Tip

Issue Planner is now in beta. Read the docs and try it out! Share your feedback on Discord.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@codecov
Copy link

codecov bot commented Feb 17, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.83%. Comparing base (5d6b41c) to head (26c3060).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #322      +/-   ##
==========================================
- Coverage   90.84%   90.83%   -0.01%     
==========================================
  Files          70       70              
  Lines        2555     2553       -2     
==========================================
- Hits         2321     2319       -2     
  Misses        234      234              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@GDYendell GDYendell merged commit 4992357 into main Feb 17, 2026
11 checks passed
@GDYendell GDYendell deleted the 314-remove_unused_options branch February 17, 2026 15:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants