Build universal (arm64+x86_64) macOS binaries - #331
Open
hlship wants to merge 2 commits into
Open
Conversation
Add arm64 and x86_64 -arch flags on Darwin so dialogc and dgdebug build as fat binaries instead of native-arch only. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Reflects the macOS build now producing fat arm64+x86_64 binaries. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
-arch arm64 -arch x86_64in CFLAGS/LDFLAGS whenuname -sis Darwin, leaving Linux and the mingw cross-builds untouched.macos-arm64tomacos-universalto reflect the change (both the upload step and the release-bundling step).Closes #330
Test plan
make --directory=./src clean allon macOS (Apple Silicon) and confirmedlipo -inforeports bothx86_64andarm64fordialogcanddgdebugbuild-macosjob builds andmake testpasses with the universal binaries