Skip to content

Created a new example to test the compilation and concepts of samplers#252

Open
karimsayedre wants to merge 12 commits intomasterfrom
sampler-concepts
Open

Created a new example to test the compilation and concepts of samplers#252
karimsayedre wants to merge 12 commits intomasterfrom
sampler-concepts

Conversation

@karimsayedre
Copy link
Contributor

No description provided.

@devshgraphicsprogramming
Copy link
Member

devshgraphicsprogramming commented Mar 23, 2026

Everything looks good, although it would be nice to try the CDF and Alias table samples at several different PoT sizes from 8 to 128*1024^2 to find the perf crossover point across sizes

Also do a 1 Reservoir sampling from size of 2 to 32 because that will likely be faster than CDF and Alias at really small sizes (same way linear search is vs binary and hashmap due to caching effects)

@devshgraphicsprogramming
Copy link
Member

Also see if you can address any of the open comments in the BxDF testing PR
#236

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants