Skip to content

refactor: extract standalone browser submodels#182

Merged
nathanhuh merged 1 commit intomainfrom
refactor/107-standalone-browser-submodels
Apr 24, 2026
Merged

refactor: extract standalone browser submodels#182
nathanhuh merged 1 commit intomainfrom
refactor/107-standalone-browser-submodels

Conversation

@nathanhuh
Copy link
Copy Markdown
Contributor

Summary

  • extract Secrets Manager, S3, and Lambda browser state/update/view logic into feature submodels
  • remove the corresponding root Model fields and app.go dispatch/view/filter branches
  • preserve existing list/detail/invoke behavior and update tests for the new ownership

Progresses #107.

Validation

  • make test
  • make build

Copy link
Copy Markdown
Contributor

@amazon-q-developer amazon-q-developer Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR successfully refactors Secrets Manager, S3, and Lambda browser functionality into standalone submodels, following the established pattern from other features. The changes cleanly separate concerns and maintain existing behavior while improving code organization.

Key Changes:

  • Extracted state management into secretsModel, s3Model, and lambdaModel structs
  • Moved update/view logic to dedicated screen files
  • Updated filter handling to use the featureSubmodel interface
  • Removed root Model field clutter

The refactoring preserves all existing functionality and test coverage. Nice work maintaining consistency with the existing submodel architecture!


You can now have the agent implement changes and create commits directly on your pull request's source branch. Simply comment with /q followed by your request in natural language to ask the agent to make changes.

@nathanhuh nathanhuh merged commit 5a1a280 into main Apr 24, 2026
2 checks passed
@nathanhuh nathanhuh deleted the refactor/107-standalone-browser-submodels branch April 24, 2026 01:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants