Skip to content

Conversation

Copy link
Contributor

Copilot AI commented Dec 2, 2025

Addresses review feedback from PR #1583 on the window recording feature implementation.

Dependency Management

  • Updated now-proto-pdu to use v0.4.2 from crates.io for stable, reproducible builds

Task Lifecycle

  • Track window monitor task with JoinHandle and await completion on shutdown to prevent race conditions
  • Made stop_window_recording async to properly await task termination

Code Quality

  • Removed redundant type annotation on run_dvc_io result
  • Extracted duplicate timestamp logic into get_current_timestamp() helper
  • Fixed module docs to clarify polling is used for title change detection

Bug Fix

  • When title tracking is disabled, preserve previous title in snapshot to avoid missing actual window changes:
// Before: updating full snapshot could mask process/exe_path changes
last_snapshot = Some(snapshot);

// After: preserve previous title when tracking disabled
let prev_title = last_snapshot.as_ref().map_or_else(String::new, |s| s.title.clone());
last_snapshot = Some(WindowSnapshot {
    process_id: snapshot.process_id,
    exe_path: snapshot.exe_path.clone(),
    title: prev_title,
});

💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.

Copilot AI and others added 2 commits December 2, 2025 14:12
Co-authored-by: pacmancoder <3994505+pacmancoder@users.noreply.github.com>
Co-authored-by: pacmancoder <3994505+pacmancoder@users.noreply.github.com>
Copilot AI changed the title [WIP] Add window recording support via now proto DVC refactor(agent): address review comments for window recording support Dec 2, 2025
Copilot AI requested a review from pacmancoder December 2, 2025 14:19
Copilot finished work on behalf of pacmancoder December 2, 2025 14:19
Co-authored-by: pacmancoder <3994505+pacmancoder@users.noreply.github.com>
Copy link
Contributor Author

Copilot AI commented Dec 2, 2025

Just as a heads up, I was blocked by some firewall rules while working on your feedback. Expand below for details.

Warning

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

  • https://api.github.com/repos/Devolutions/now-proto/commits/now-proto-pdu/v0.4.2
    • Triggering command: /home/REDACTED/.rustup/toolchains/1.90.0-x86_64-REDACTED-linux-gnu/bin/cargo /home/REDACTED/.rustup/toolchains/1.90.0-x86_64-REDACTED-linux-gnu/bin/cargo check -p devolutions-session --features dvc (http block)

If you need me to access, download, or install something from one of these locations, you can either:

Copilot AI requested a review from pacmancoder December 2, 2025 15:42
Copilot finished work on behalf of pacmancoder December 2, 2025 15:42
@pacmancoder pacmancoder marked this pull request as ready for review December 2, 2025 15:56
@pacmancoder pacmancoder merged commit 8a56ad0 into feat/window-title-recording Dec 2, 2025
69 of 76 checks passed
@pacmancoder pacmancoder deleted the copilot/sub-pr-1583 branch December 2, 2025 15:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants