Load bundle files passed on the command line - #5310
Merged
Gabriel Dufresne (GabrielDuf) merged 3 commits intoAug 21, 2026
Merged
Conversation
Copilot started reviewing on behalf of
Gabriel Dufresne (GabrielDuf)
August 21, 2026 14:15
View session
Contributor
There was a problem hiding this comment.
Pull request overview
Adds command-line package bundle loading to Avalonia startup and single-instance forwarding.
Changes:
- Resolves, validates, and normalizes bundle paths.
- Processes bundles after application initialization.
- Adds argument-resolution tests and project links.
Reviewed changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
src/Shared/StartupBundleArguments.cs |
Implements bundle argument parsing. |
src/UniGetUI.Avalonia/Infrastructure/StartupArgumentProcessor.cs |
Loads resolved startup bundles. |
src/UniGetUI.Avalonia/Infrastructure/AvaloniaAppHost.cs |
Normalizes and buffers forwarded arguments. |
src/UniGetUI.Avalonia/Infrastructure/AvaloniaBootstrapper.cs |
Exposes initialization completion. |
src/UniGetUI.Avalonia/App.axaml.cs |
Integrates initial and secondary processing. |
src/UniGetUI.Avalonia/ViewModels/MainWindowViewModel.cs |
Adds file-based bundle loading. |
src/UniGetUI.Avalonia/UniGetUI.Avalonia.csproj |
Includes shared argument logic. |
src/UniGetUI.Tests/StartupBundleArgumentsTests.cs |
Tests bundle argument handling. |
src/UniGetUI.Tests/UniGetUI.Tests.csproj |
Includes shared logic in tests. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Marc-André Moreau (mamoreau-devolutions)
approved these changes
Aug 21, 2026
Gabriel Dufresne (GabrielDuf)
deleted the
fix/5248-bundle-file-cli-argument
branch
August 21, 2026 20:02
4 tasks
4 tasks
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces robust handling and processing of package bundle files passed as command-line arguments, including normalization, validation, and integration with the application startup process. It also adds comprehensive tests and improves the reliability of handling arguments across different application entry points.
Startup bundle argument handling and processing:
StartupBundleArgumentsclass to centralize the logic for identifying, validating, and normalizing package bundle file arguments (such as.ubundle,.json,.yaml,.xml) from the command line. This includes resolving relative paths, ignoring unsupported/missing files, and skipping arguments that are flags or their values. (src/Shared/StartupBundleArguments.cs, src/Shared/StartupBundleArguments.csR1-R107)StartupBundleArgumentsinto the main application startup and single-instance logic, ensuring bundle files are correctly resolved and normalized before further processing. (src/UniGetUI.Avalonia/Infrastructure/AvaloniaAppHost.cs,Startup argument processing and user feedback:
StartupArgumentProcessorto process bundle files on startup, load them into the main window, and log warnings if bundles are ignored (e.g., in daemon mode or if the main window/view model is unavailable). (src/UniGetUI.Avalonia/Infrastructure/StartupArgumentProcessor.cs, src/UniGetUI.Avalonia/Infrastructure/StartupArgumentProcessor.csR1-R64)src/UniGetUI.Avalonia/App.axaml.cs,Reliability and single-instance improvements:
src/UniGetUI.Avalonia/Infrastructure/AvaloniaAppHost.cs, src/UniGetUI.Avalonia/Infrastructure/AvaloniaAppHost.csL21-R56)src/UniGetUI.Avalonia/Infrastructure/AvaloniaBootstrapper.cs,Testing and project structure:
StartupBundleArguments, covering supported extensions, path resolution, quoting, unsupported/missing files, and normalization logic. (src/UniGetUI.Tests/StartupBundleArgumentsTests.cs, src/UniGetUI.Tests/StartupBundleArgumentsTests.csR1-R141)src/UniGetUI.Avalonia/UniGetUI.Avalonia.csproj,View model support:
src/UniGetUI.Avalonia/ViewModels/MainWindowViewModel.cs, src/UniGetUI.Avalonia/ViewModels/MainWindowViewModel.csR761-R766)