feat(activex): prompt for gateway credentials - #1763
Open
Marc-André Moreau (mamoreau-devolutions) wants to merge 1 commit into
Open
feat(activex): prompt for gateway credentials#1763Marc-André Moreau (mamoreau-devolutions) wants to merge 1 commit into
Marc-André Moreau (mamoreau-devolutions) wants to merge 1 commit into
Conversation
Prompt for non-persistent credentials for a configured RD Gateway. Keep them scoped to the connection attempt and leave cancellation disconnected.
Marc-André Moreau (mamoreau-devolutions)
deployed
to
llm-providers
August 22, 2026 03:18 — with 
GitHub Actions
Active
GitHub Actions
Active
Copilot started reviewing on behalf of
Marc-André Moreau (mamoreau-devolutions)
August 22, 2026 03:18
View session
github-actions
Bot
added
maintainer-required
Contributor
There was a problem hiding this comment.
Pull request overview
Adds non-persistent RD Gateway credential prompting to the ActiveX connection flow.
Changes:
- Adds a gateway-specific Windows credential prompt.
- Keeps prompted credentials local to the connection attempt.
- Leaves canceled prompts disconnected and tests transport mapping.
Comment on lines
+7630
to
+7631
| let mut username = credential_prompt_buffer("", CREDUI_MAX_USERNAME_LENGTH); | ||
| let mut password = credential_prompt_buffer("", CREDUI_MAX_PASSWORD_LENGTH); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prompt for non-persistent credentials for a configured RD Gateway.
Keep them scoped to the connection attempt and leave cancellation disconnected.