feat(mstsgu): add extended-auth packet codecs - #1761
Open
Marc-André Moreau (mamoreau-devolutions) wants to merge 1 commit into
Open
feat(mstsgu): add extended-auth packet codecs#1761Marc-André Moreau (mamoreau-devolutions) wants to merge 1 commit into
Marc-André Moreau (mamoreau-devolutions) wants to merge 1 commit into
Conversation
Preserve advertised handshake extended-auth flags, including unknown bits, and encode/decode extended-auth packet blobs with exact lengths. Add wire vectors for flag combinations, packet round trips, malformed blobs, and u16 blob boundaries.
Marc-André Moreau (mamoreau-devolutions)
deployed
to
llm-providers
August 22, 2026 02:06 — with 
GitHub Actions
Active
GitHub Actions
Active
Copilot started reviewing on behalf of
Marc-André Moreau (mamoreau-devolutions)
August 22, 2026 02:06
View session
Contributor
There was a problem hiding this comment.
Pull request overview
Adds spec-conformant extended-auth handling to the MSTSGU codec.
Changes:
- Preserves known and unknown handshake authentication flags.
- Corrects field widths and adds extended-auth blob codec validation.
- Adds wire-format, malformed-input, and boundary tests.
No material findings were identified.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
crates/ironrdp-mstsgu/src/proto.rs |
Updates extended-auth flags and packet codecs. |
crates/ironrdp-mstsgu/tests/http_control.rs |
Adds protocol vectors and boundary tests. |
github-actions
Bot
added
maintainer-required
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Preserve advertised handshake extended-auth flags, including unknown bits, and encode/decode extended-auth packet blobs with exact lengths.
Add wire vectors for flag combinations, packet round trips, malformed blobs, and u16 blob boundaries.