test(extra): centralize remaining integration tests - #1748
Open
Benoît Cortier (CBenoit) wants to merge 4 commits into
Open
test(extra): centralize remaining integration tests#1748Benoît Cortier (CBenoit) wants to merge 4 commits into
Benoît Cortier (CBenoit) wants to merge 4 commits into
Conversation
Benoît Cortier (CBenoit)
temporarily deployed
to
llm-providers
August 21, 2026 09:43 — with 
GitHub Actions
Inactive
GitHub Actions
Inactive
github-actions
Bot
added
maintainer-required
Benoît Cortier (CBenoit)
temporarily deployed
to
llm-providers
August 21, 2026 10:02 — with
GitHub Actions
Inactive
GitHub Actions
Inactive
github-actions
Bot
added
scope/tooling
Benoît Cortier (CBenoit)
temporarily deployed
to
llm-providers
August 21, 2026 10:29 — with
GitHub Actions
Inactive
GitHub Actions
Inactive
Contributor
There was a problem hiding this comment.
Pull request overview
Centralizes native TLS and Windows RDPDR integration coverage in the extra testsuite.
Changes:
- Moves test registration into the shared integration harness.
- Updates dependencies and xtask TLS checks.
- Adds Windows filesystem and native TLS fixtures.
Protocol and documentation passes were skipped because runtime protocol behavior and documentation are unchanged.
Reviewed changes
Copilot reviewed 8 out of 12 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
xtask/src/check.rs |
Uses the centralized native TLS harness. |
crates/ironrdp-tls/src/lib.rs |
Narrows native TLS conditional import. |
crates/ironrdp-tls/Cargo.toml |
Removes standalone test configuration. |
crates/ironrdp-testsuite-extra/tests/tls/native_tls.rs |
Cleans the migrated TLS test. |
crates/ironrdp-testsuite-extra/tests/tls/mod.rs |
Registers native TLS tests. |
crates/ironrdp-testsuite-extra/tests/tls/certs/server-key.pem |
Adds the TLS test key. |
crates/ironrdp-testsuite-extra/tests/tls/certs/server-cert.pem |
Adds the TLS test certificate. |
crates/ironrdp-testsuite-extra/tests/rdpdr/windows_backend.rs |
Adds Windows backend integration coverage. |
crates/ironrdp-testsuite-extra/tests/rdpdr/mod.rs |
Registers RDPDR tests. |
crates/ironrdp-testsuite-extra/tests/main.rs |
Enables the new test modules. |
crates/ironrdp-testsuite-extra/Cargo.toml |
Adds harness dependencies. |
Cargo.lock |
Records dependency-edge changes. |
Move native TLS certificate-policy and Windows RDPDR filesystem coverage into the extra testsuite's sole integration harness. Product crates no longer expose standalone Cargo test targets. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Remove commands targeting the deleted TLS test binary so the test checks run the centralized native-TLS harness. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Only import tokio-native-tls when its native TLS backend feature is enabled. The product crate no longer carries the former test-only dependency. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Benoît Cortier (CBenoit)
force-pushed
the
cbenoit-centralize-tls-rdpdr-tests
branch
from
August 21, 2026 11:09
0cdea4f to
71501a2
Compare
Benoît Cortier (CBenoit)
temporarily deployed
to
llm-providers
August 21, 2026 11:09 — with
GitHub Actions
Inactive
GitHub Actions
Inactive
Drop placeholder imports and direct dependencies already supplied by the RDPDR test stack. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Benoît Cortier (CBenoit)
deployed
to
llm-providers
August 21, 2026 15:47 — with
GitHub Actions
Active
GitHub Actions
Active
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Move native TLS certificate-policy and Windows RDPDR filesystem coverage into the extra testsuite's sole integration harness. Product crates no longer expose standalone Cargo test targets. Update xtask's native TLS checks to exercise the centralized harness.
Co-authored-by: Copilot App 223556219+Copilot@users.noreply.github.com