test(extra): centralize replay integration tests - #1747
Open
Benoît Cortier (CBenoit) wants to merge 2 commits into
Open
test(extra): centralize replay integration tests#1747Benoît Cortier (CBenoit) wants to merge 2 commits into
Benoît Cortier (CBenoit) wants to merge 2 commits into
Conversation
Benoît Cortier (CBenoit)
temporarily deployed
to
llm-providers
August 21, 2026 08:50 — with 
GitHub Actions
Inactive
GitHub Actions
Inactive
github-actions
Bot
added
maintainer-required
Benoît Cortier (CBenoit)
force-pushed
the
cbenoit-consolidate-replay-tests
branch
from
August 21, 2026 09:21
794e1e6 to
c48273b
Compare
Benoît Cortier (CBenoit)
changed the title
Benoît Cortier (CBenoit)
temporarily deployed
to
llm-providers
August 21, 2026 09:22 — with
GitHub Actions
Inactive
GitHub Actions
Inactive
github-actions
Bot
added
size/M
Centralize replay coverage in the extra suite and build the binary once. Preserve gateway, malformed-input, key-log cleanup, and binary invocation coverage. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Rely on the centralized harness allowance after moving RPC-over-HTTP coverage. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Benoît Cortier (CBenoit)
force-pushed
the
cbenoit-consolidate-replay-tests
branch
from
August 21, 2026 11:02
c48273b to
f75b935
Compare
Benoît Cortier (CBenoit)
temporarily deployed
to
llm-providers
August 21, 2026 11:02 — with
GitHub Actions
Inactive
GitHub Actions
Inactive
Contributor
There was a problem hiding this comment.
Pull request overview
Centralizes capture-replay integration coverage in the extra testsuite’s single test binary. No material issues identified.
Changes:
- Moves gateway, RPC-over-HTTP, key-log, and CLI coverage into the extra suite.
- Shares cached workspace-binary build logic with agent tests.
- Adds required test dependencies and lockfile entries.
Protocol review was skipped because protocol behavior is unchanged.
Reviewed changes
Copilot reviewed 7 out of 8 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
crates/ironrdp-testsuite-extra/tests/main.rs |
Registers replay tests and adds shared binary lookup. |
crates/ironrdp-testsuite-extra/tests/capture_replay/mod.rs |
Organizes replay modules and caches the binary path. |
crates/ironrdp-testsuite-extra/tests/capture_replay/keylog.rs |
Centralizes key-log and CLI tests. |
crates/ironrdp-testsuite-extra/tests/capture_replay/gateway.rs |
Centralizes gateway tests. |
crates/ironrdp-testsuite-extra/tests/capture_replay/gateway_rpch.rs |
Centralizes RPC-over-HTTP tests. |
crates/ironrdp-testsuite-extra/tests/agent/mod.rs |
Reuses shared binary-build logic. |
crates/ironrdp-testsuite-extra/Cargo.toml |
Adds replay test dependencies. |
Cargo.lock |
Records dependency updates. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Centralize replay and RPC-over-HTTP coverage in the extra suite and build the binary once.
Preserve gateway, malformed-input, key-log cleanup, and binary invocation coverage.
Co-authored-by: Copilot App 223556219+Copilot@users.noreply.github.com