remove protected properties from device map.#1
Merged
DeveloperRejaul merged 1 commit intoDeveloperRejaul:mainfrom Mar 31, 2026
Conversation
Owner
🙌 Thanks for the Contribution!Thank you for this PR — really appreciate you taking the time to address the USB permission issues on newer Android versions. The approach of limiting I've merged your changes into the library ✅ Thanks again for the thoughtful fix and contribution! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Newer versions of Android require permissions to access UsbDevice properties which used to be "open". As such, getDeviceList always fails with permission errors.
This PR strips most properties from the device map created from getDeviceList, so that only unprotected properties are accessed.
Once the user requests permissions for a specific device, they can then access protected properties, such as serialNumber.