Skip to content

Add support for using this thread pool with coroutines #14

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
DeveloperPaul123 wants to merge 36 commits into
base: main
Choose a base branch
from
Draft

Add support for using this thread pool with coroutines #14

DeveloperPaul123 wants to merge 36 commits into from

Conversation

@DeveloperPaul123
Copy link
Owner

@DeveloperPaul123 DeveloperPaul123 commented Sep 12, 2022 •
edited
Loading

Note
This is on hold until I can ensure that the necessary build flags are properly set in the dp::thread-pool for coroutine support. It seems that down-stream projects for coroutines don't set these in the targets properly but I want dp::thread-pool to do this.

Changes

  • Updated CPM.cmake version
  • Added schedule() function to allow for running coroutines on the thread pool
  • Added batch enqueue() function to better compare to coroutine performance

DeveloperPaul123 and others added 30 commits September 12, 2022 12:43
@DeveloperPaul123
Update CPM version
9d27555
@DeveloperPaul123
Add basic support for running coroutines on pool
da80813 
Added a basic awaitable type and function to allow for running coroutines on the thread pool
@DeveloperPaul123
WIP: Add coroutine thread pool benchmark
83bec54
@DeveloperPaul123
Add bulk enqueue function
c493f52 
Add ability to enqueue a range of void() functions
@DeveloperPaul123
Do not build benchmarks for style check CI
e8b9e6d
@DeveloperPaul123
Add ccache support
3be61ea
@DeveloperPaul123
Try to correct errors in tests
e42fa8f
@DeveloperPaul123
Another CPM update
107305e
@DeveloperPaul123
Add benchmark for batched task execution
fa20ee6 
Also changed benchmarks so that only 1 runs in debug mode for the dp::thread_pool
@DeveloperPaul123
Build fixes for coroutines and clang
94fc466
@DeveloperPaul123
Improve batched task execution and remove modulus
691414b 
Removed modulus calculation for assigning tasks to thread queues.
@DeveloperPaul123
Further safety for function invocation in thread
dceb94f
@DeveloperPaul123
Make schedule() nodiscard
0b50e1f
@DeveloperPaul123
Documentation update
adce8c8
@DeveloperPaul123
Update to Clang 14 on CI
136faee
@DeveloperPaul123
Formatting updates
2f71162
@DeveloperPaul123
Add badges to README
67c4c65
use feature test macro to check feature available
28c6609
@DeveloperPaul123
Merge pull request #15 from cauliyang/master
dad69c1 
Use feature test macro from C++20's `<version>` header to check for `std::move_only_function` support
@DeveloperPaul123
Update CPM version
e7dc22c
@DeveloperPaul123
Add basic support for running coroutines on pool
bd3986d 
Added a basic awaitable type and function to allow for running coroutines on the thread pool
@DeveloperPaul123
WIP: Add coroutine thread pool benchmark
efe7386
@DeveloperPaul123
Add bulk enqueue function
48ebc32 
Add ability to enqueue a range of void() functions
@DeveloperPaul123
Do not build benchmarks for style check CI
abf4559
@DeveloperPaul123
Add ccache support
661b54c
@DeveloperPaul123
Try to correct errors in tests
c9b6e58
@DeveloperPaul123
Another CPM update
8df5965
@DeveloperPaul123
Add benchmark for batched task execution
463b9e8 
Also changed benchmarks so that only 1 runs in debug mode for the dp::thread_pool
@DeveloperPaul123
Build fixes for coroutines and clang
3d3c35e
@DeveloperPaul123
Improve batched task execution and remove modulus
6eb7c36 
Removed modulus calculation for assigning tasks to thread queues.
@DeveloperPaul123 DeveloperPaul123 changed the title Adding support for using this thread pool with coroutines Add support for using this thread pool with coroutines May 31, 2023
@sonarqubecloud
Copy link

sonarqubecloud bot commented Aug 14, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
1 Security Hotspot
B Maintainability Rating on New Code (required ≥ A)
E Reliability Rating on New Code (required ≥ A)

See analysis details on SonarCloud

Catch issues before they fail your Quality Gate with our IDE extension SonarLint

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@DeveloperPaul123