Skip to content

[jules] ux: Complete skeleton loading for HomeScreen groups#312

Open
Devasy wants to merge 1 commit intomainfrom
jules-mobile-skeleton-loading-12719780251013376740
Open

[jules] ux: Complete skeleton loading for HomeScreen groups#312
Devasy wants to merge 1 commit intomainfrom
jules-mobile-skeleton-loading-12719780251013376740

Conversation

@Devasy
Copy link
Copy Markdown
Owner

@Devasy Devasy commented Apr 3, 2026

This PR implements a generic skeleton loading system for the React Native mobile app to provide a much smoother perceived loading experience. It introduces a reusable Skeleton primitive and a context-specific GroupListSkeleton for the HomeScreen. It replaces ActivityIndicator spinners and replaces inline shimering logic in FriendsScreen to unify loading states across the application.


PR created automatically by Jules for task 12719780251013376740 started by @Devasy23

Summary by CodeRabbit

Release Notes

  • New Features

    • Implemented animated skeleton loading placeholders on mobile that replace loading spinners with native-feeling animated card skeletons for improved visual feedback
  • Refactor

    • Introduced reusable skeleton components for more consistent loading experiences across home and friends screens
  • Documentation

    • Updated project changelog with skeleton loading feature documentation

Co-authored-by: Devasy23 <110348311+Devasy23@users.noreply.github.com>
@google-labs-jules
Copy link
Copy Markdown
Contributor

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@Devasy Devasy requested a review from vrajpatelll as a code owner April 3, 2026 19:47
@netlify
Copy link
Copy Markdown

netlify bot commented Apr 3, 2026

Deploy Preview for split-but-wiser canceled.

Name Link
🔨 Latest commit db8673b
🔍 Latest deploy log https://app.netlify.com/projects/split-but-wiser/deploys/69d0195cd29bf100081ea914

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented Apr 3, 2026

Walkthrough

Mobile skeleton loading implementation replaces blank screens and loading indicators with animated placeholder components. Two new skeleton UI components were created and integrated into HomeScreen and FriendsScreen. Documentation updated to track completion and new skeleton component infrastructure.

Changes

Cohort / File(s) Summary
Documentation Updates
.Jules/changelog.md, .Jules/todo.md
Added changelog entry documenting skeleton loading feature with new components and screen updates. Marked HomeScreen loading task complete with expanded scope including FriendsScreen and reusable skeleton infrastructure.
New Skeleton Components
mobile/components/ui/Skeleton.js, mobile/components/skeletons/GroupListSkeleton.js
Created base Skeleton component with configurable dimensions and animated opacity loop (700ms cycle using Animated.loop). Created GroupListSkeleton component that renders stacked skeleton cards with accessibility role and default count of 3.
Screen Integrations
mobile/screens/HomeScreen.js, mobile/screens/FriendsScreen.js
HomeScreen: replaced centered ActivityIndicator with GroupListSkeleton during loading. FriendsScreen: refactored inline animated skeleton logic to reuse Skeleton component for avatar and text placeholders; removed custom opacity animation logic and unused style definitions.

Possibly related PRs

Suggested reviewers

  • vrajpatelll
🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately summarizes the main change: implementing skeleton loading for HomeScreen groups, which is the primary objective of this PR. It's specific, concise, and clearly describes the core modification.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@codecov
Copy link
Copy Markdown

codecov bot commented Apr 3, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
⚠️ Please upload report for BASE (main@9404621). Learn more about missing BASE report.
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #312   +/-   ##
=======================================
  Coverage        ?   63.55%           
=======================================
  Files           ?       21           
  Lines           ?     2456           
  Branches        ?      254           
=======================================
  Hits            ?     1561           
  Misses          ?      831           
  Partials        ?       64           
Components Coverage Δ
Authentication System 71.35% <ø> (?)
Expense Management 70.15% <ø> (?)
Group Management 73.78% <ø> (?)
User Management 97.16% <ø> (?)
Backend Core 70.78% <ø> (?)
🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Copy Markdown
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Inline comments:
In @.Jules/todo.md:
- Around line 60-63: Two entries for the completed task "Complete skeleton
loading for HomeScreen groups" have inconsistent "Files modified" lists; update
the .Jules/todo.md entries so both occurrences list the exact same files
(`mobile/screens/HomeScreen.js`, `mobile/components/ui/Skeleton.js`,
`mobile/components/skeletons/GroupListSkeleton.js`) to keep audit history
consistent (also check and update the duplicate occurrence referenced around
lines 173-176).
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro

Run ID: c93b2f4e-3c19-4462-8c86-8a9c3e52faee

📥 Commits

Reviewing files that changed from the base of the PR and between 9404621 and db8673b.

📒 Files selected for processing (6)
  • .Jules/changelog.md
  • .Jules/todo.md
  • mobile/components/skeletons/GroupListSkeleton.js
  • mobile/components/ui/Skeleton.js
  • mobile/screens/FriendsScreen.js
  • mobile/screens/HomeScreen.js

Comment on lines +60 to 63
- [x] **[ux]** Complete skeleton loading for HomeScreen groups
- Completed: 2026-04-03
- File: `mobile/screens/HomeScreen.js`, `mobile/components/ui/Skeleton.js`, `mobile/components/skeletons/GroupListSkeleton.js`
- Context: Replace ActivityIndicator with skeleton group cards
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟡 Minor

Unify task metadata across both entries for the same completed item.

The file list differs between the two entries for this task, which can confuse audit history. Keep the "Files modified" set consistent in both places.

📝 Suggested doc-only fix
--  - File: `mobile/screens/HomeScreen.js`, `mobile/components/ui/Skeleton.js`, `mobile/components/skeletons/GroupListSkeleton.js`
+-  - Files modified: `mobile/screens/HomeScreen.js`, `mobile/screens/FriendsScreen.js`, `mobile/components/ui/Skeleton.js`, `mobile/components/skeletons/GroupListSkeleton.js`

Also applies to: 173-176

🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.

In @.Jules/todo.md around lines 60 - 63, Two entries for the completed task
"Complete skeleton loading for HomeScreen groups" have inconsistent "Files
modified" lists; update the .Jules/todo.md entries so both occurrences list the
exact same files (`mobile/screens/HomeScreen.js`,
`mobile/components/ui/Skeleton.js`,
`mobile/components/skeletons/GroupListSkeleton.js`) to keep audit history
consistent (also check and update the duplicate occurrence referenced around
lines 173-176).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant