Rendering Update #4
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author
|
TODO fix reflection bounces and figure out what to do with fresnel underwater |
Author
|
|
Devaniti
requested changes
Jul 8, 2024
| const Vector4& forward) | ||
| { | ||
| static const float defaultMoveSpeed = 15.0f; | ||
| //TODO move into separate confing maybe? |
Owner
There was a problem hiding this comment.
Suggested change
| //TODO move into separate confing maybe? | |
| //TODO make this per scene option |
| { | ||
| static const float defaultMoveSpeed = 15.0f; | ||
| //TODO move into separate confing maybe? | ||
| static const float defaultMoveSpeed = 35.0f; |
Owner
There was a problem hiding this comment.
Please don't change default params in master. It's meant for default scene.
Suggested change
| static const float defaultMoveSpeed = 35.0f; | |
| static const float defaultMoveSpeed = 15.0f; |
| #define BLK_HIGH_QUALITY_RAY_DIFFERENTIALS 1 | ||
|
|
||
| #define BLK_REFLECTION_TMIN 0.01f | ||
| #define BLK_REFLECTION_TMIN 0.5f |
Owner
There was a problem hiding this comment.
Suggested change
| #define BLK_REFLECTION_TMIN 0.5f | |
| // TODO Make this per scene option | |
| #define BLK_REFLECTION_TMIN 0.01f |
| #define BLK_REFLECTION_TMIN 0.5f | ||
| #define BLK_REFLECTION_TMAX 10000.0f | ||
| #define BLK_REFRACTION_TMIN 0.001f | ||
| #define BLK_REFRACTION_TMIN 0.5f |
Owner
There was a problem hiding this comment.
Suggested change
| #define BLK_REFRACTION_TMIN 0.5f | |
| #define BLK_REFRACTION_TMIN 0.001f |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.