Repository navigation
Conversation
Vendor the verified 4.1.7 source and MIT license, replace package imports, and add rendering regression coverage. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> # Conflicts: # package-lock.json
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
No active review issues are recorded for the local callsite-record integration.
No open issues 🎉
What changed in this PR
This PR brings callsite-record into TestCafe’s source tree to simplify maintenance of callsite capture and error rendering.
Changes:
- Adds the implementation, renderers, type declarations, and original MIT attribution.
- Redirects internal imports to the local module and updates dependencies and lockfile resolutions.
- Adds regression tests and includes the license in build output.
| File | Description |
|---|---|
| test/server/data/test-callsite/index.js | Uses the local module in the callsite fixture. |
| test/server/data/callsite-record/source.js | Adds source content for rendering tests. |
| test/server/callsite-record-test.js | Tests capture, rendering, escaping, failures, and attribution. |
| src/utils/render-callsite-sync.js | Uses local renderers. |
| src/utils/prerender-callsite.ts | Uses the local callsite type. |
| src/utils/get-renderes.ts | Uses local types and renderers. |
| src/utils/callsite-record/renderers/no-color.js | Adds plain-text rendering. |
| src/utils/callsite-record/renderers/index.d.ts | Adds renderer type declarations. |
| src/utils/callsite-record/renderers/html.js | Adds HTML rendering with escaping. |
| src/utils/callsite-record/renderers/default.js | Adds colored terminal rendering. |
| src/utils/callsite-record/README.md | Documents provenance and distribution. |
| src/utils/callsite-record/LICENSE | Preserves the original MIT license. |
| src/utils/callsite-record/index.js | Adds callsite capture and rendering implementation. |
| src/utils/callsite-record/index.d.ts | Adds callsite API declarations. |
| src/test-run/request/send.ts | Uses the local callsite type. |
| src/test-run/request/create-request-options.ts | Uses the local callsite type. |
| src/test-run/index.ts | Uses the local callsite type. |
| src/test-run/bookmark.ts | Uses the local callsite type. |
| src/errors/test-run/render-error-template/utils.ts | Uses local error renderers. |
| src/errors/get-callsite.js | Uses local capture and updates its explanatory comment. |
| src/assertions/executor.ts | Uses the local callsite type. |
| src/api/test-controller/index.d.ts | References local callsite declarations. |
| src/api/test-controller/assertion.ts | Uses the local callsite type. |
| package.json | Replaces the package dependency and adds dependency overrides. |
| package-lock.json | Records dependency migration and resolution changes. |
| Gulpfile.js | Copies the callsite license into build output. |
Review effort: Balanced
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added the callsite-record package to the TestCafe repository to simplify maintenance