GridCore data: Remove DataSourceAdapter dynamic member-copy and type _dataSource - #34980
Draft
bit-byte0 wants to merge 5 commits into
Draft
Conversation
…atacontroller-type-datasource-adapter-26_2 # Conflicts: # packages/devextreme/js/__internal/grids/data_grid/grouping/m_grouping.ts
…urce for unconditional delegates
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Removes the runtime block in DataSourceAdapter that dynamically copied every
DataSourcemethod onto the adapter, and typesDataController._dataSourceasDataSourceAdapterinstead ofanyHow
Replaced the dynamic copy with explicit typed delegates on the adapter, promoted the adapter's consumed methods to
public, and narrowed_dataSourceto the concrete adapter subtype in the virtual scrolling and tree_list extenders where subclass methods are used