Skip to content

chore(deps): bump axe to v4.13.0 #34935

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
EugeniyKiyashko wants to merge 1 commit into
base: main
Choose a base branch
from
Open

chore(deps): bump axe to v4.13.0 #34935

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion apps/demos/Demos/Stepper/StepTemplate/Angular/app/app.component.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,6 +41,11 @@
[elementAttr]="{ 'aria-labelledby': 'label-iconOnly' }"
>
<div *dxTemplate="let data of 'item'">
<i class="dx-icon" [class]="'dx-icon-' + data.icon"></i>
<i
class="dx-icon"
[class]="'dx-icon-' + data.icon"
role="img"
[attr.aria-label]="data.label"
></i>
</div>
</dx-stepper>
5 changes: 3 additions & 2 deletions apps/demos/Demos/Stepper/StepTemplate/React/IconOnly.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,10 +2,11 @@ import React from 'react';

interface IconOnlyProps {
icon: string;
label: string;
}

export default function IconOnly({ icon }: IconOnlyProps) {
export default function IconOnly({ icon, label }: IconOnlyProps) {
return (
<i className={`dx-icon dx-icon-${icon}`}></i>
<i className={`dx-icon dx-icon-${icon}`} role="img" aria-label={label}></i>
);
}
10 changes: 8 additions & 2 deletions apps/demos/Demos/Stepper/StepTemplate/ReactJs/IconOnly.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,11 @@
import React from 'react';

export default function IconOnly({ icon }) {
return <i className={`dx-icon dx-icon-${icon}`}></i>;
export default function IconOnly({ icon, label }) {
return (
<i
className={`dx-icon dx-icon-${icon}`}
role="img"
aria-label={label}
></i>
);
}
6 changes: 5 additions & 1 deletion apps/demos/Demos/Stepper/StepTemplate/Vue/App.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,11 @@
>
<template #item="{ data }">
<div>
<i :class="'dx-icon dx-icon-' + data.icon"/>
<i
:class="'dx-icon dx-icon-' + data.icon"
role="img"
:aria-label="data.label"
/>
</div>
</template>
</DxStepper>
Expand Down
2 changes: 1 addition & 1 deletion apps/demos/Demos/Stepper/StepTemplate/jQuery/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ $(() => {
linear: false,
elementAttr: { 'aria-labelledby': 'label-iconOnly' },
itemTemplate(data) {
return `<i class="dx-icon dx-icon-${data.icon}"></i>`;
return `<i class="dx-icon dx-icon-${data.icon}" role="img" aria-label="${data.label}"></i>`;
},
});
});
2 changes: 1 addition & 1 deletion apps/demos/Demos/TabPanel/Overview/Angular/app/app.component.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -104,7 +104,7 @@

::ng-deep .task-item-info {
font-size: 12px;
opacity: 0.6;
opacity: 0.65;
}

::ng-deep .task-item-pseudo-button {
Expand Down
2 changes: 1 addition & 1 deletion apps/demos/Demos/TabPanel/Overview/React/styles.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -104,7 +104,7 @@

.task-item-info {
font-size: 12px;
opacity: 0.6;
opacity: 0.65;
}

.task-item-pseudo-button {
Expand Down
2 changes: 1 addition & 1 deletion apps/demos/Demos/TabPanel/Overview/ReactJs/styles.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -104,7 +104,7 @@

.task-item-info {
font-size: 12px;
opacity: 0.6;
opacity: 0.65;
}

.task-item-pseudo-button {
Expand Down
2 changes: 1 addition & 1 deletion apps/demos/Demos/TabPanel/Overview/Vue/TaskItem.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,7 @@ withDefaults(defineProps<{

.task-item-info {
font-size: 12px;
opacity: 0.6;
opacity: 0.65;
}

.task-item-pseudo-button {
Expand Down
2 changes: 1 addition & 1 deletion apps/demos/Demos/TabPanel/Overview/jQuery/styles.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -104,7 +104,7 @@

.task-item-info {
font-size: 12px;
opacity: 0.6;
opacity: 0.65;
}

.task-item-pseudo-button {
Expand Down
15 changes: 15 additions & 0 deletions apps/demos/testing/common.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -112,6 +112,21 @@ const getIgnoredRules = (testName) => {
'Gantt-Validation': ['aria-required-parent', 'aria-valid-attr-value'],

'Localization-UsingGlobalize': ['label'],

// Appointments painted with saturated resource colors keep the theme's dark text,
// so their title/date contrast drops below AA. Needs a scheduler-level fix.
'Scheduler-AppointmentCountPerCell': ['color-contrast'],
'Scheduler-ContextMenu': ['color-contrast'],
'Scheduler-GroupByDate': ['color-contrast'],
'Scheduler-GroupingByResources': ['color-contrast'],
'Scheduler-RecurringAppointments': ['color-contrast'],
'Scheduler-ResolveTimeConflicts': ['color-contrast'],
'Scheduler-Timelines': ['color-contrast'],
'Scheduler-VirtualScrolling': ['color-contrast'],

// Icon-only tabs render no text, so they have no accessible name.
// Naming them needs Tabs widget support (like Button labels icon-only buttons).
'Tabs-Overview': ['aria-tab-name'],
};

return [
Expand Down
27 changes: 7 additions & 20 deletions packages/devextreme-scss/scss/widgets/fluent/tabs/layout/tab/_base.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,21 +31,13 @@
}

.dx-tab-text .dx-tab-text-span {
visibility: visible;

.dx-tab-text-span-pseudo {
visibility: hidden;
}
font-weight: $fluent-tab-font-weight-accent;
}
}

&.dx-state-disabled {
color: $tabs-tab-disabled-color;

.dx-tab-text .dx-tab-text-span-pseudo {
color: $tabs-tab-disabled-color;
}

.dx-icon {
color: $tabs-tab-icon-disabled-color;
}
Expand All @@ -61,22 +53,17 @@
line-height: $fluent-line-height;

.dx-tab-text-span {
position: relative;
display: block;
font-weight: $fluent-tab-font-weight-accent;
visibility: hidden;
font-weight: $fluent-tab-font-weight-basic;
}

// The hidden zero-height pseudo span reserves the accent-weight (selected) width; the visible text span provides the tab's accessible name.
.dx-tab-text-span-pseudo {
position: absolute;
top: 0;
right: 0;
bottom: 0;
left: 0;
display: block;
height: 0;
pointer-events: none;
color: $tabs-tab-color;
font-weight: $fluent-tab-font-weight-basic;
visibility: visible;
font-weight: $fluent-tab-font-weight-accent;
visibility: hidden;
}
}

Expand Down
32 changes: 16 additions & 16 deletions pnpm-lock.yaml
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion pnpm-workspace.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,7 @@ overrides:
"dompurify@<=3.4.12": "^3.4.13"
"nanoid@<3.3.17": "^3.3.17"
catalog:
axe-core: 4.11.3
axe-core: 4.13.0
inferno: ^8.2.3
inferno-hydrate: ^8.2.3
inferno-create-element: ^8.2.3
Expand Down
Loading