PivotGrid - KBN - Open cell context menu from keyboard#34263
Open
bit-byte0 wants to merge 1 commit into
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adds a small PivotGrid keyboard-navigation utility to detect the standard “open context menu” keyboard gestures on header cells (Shift+F10 and the dedicated ContextMenu key). This fits into the __internal/grids/pivot_grid/keyboard_navigation helpers alongside existing navigation utilities and establishes a base-agnostic predicate for future widget wiring.
Changes:
- Added
isContextMenuKeyEventpredicate for recognizingContextMenuandShift+F10. - Added Jest coverage for the predicate, including positive and negative cases.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| packages/devextreme/js/__internal/grids/pivot_grid/keyboard_navigation/cell_context_menu.ts | Introduces the isContextMenuKeyEvent helper to detect context-menu keyboard triggers. |
| packages/devextreme/js/__internal/grids/pivot_grid/keyboard_navigation/cell_context_menu.test.ts | Adds Jest tests validating detection and non-detection scenarios for the helper. |
bit-byte0
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Adds a small PivotGrid keyboard-navigation helper that recognizes the open-context-menu keyboard gesture (
Shift+F10and the dedicatedContextMenukey) on header cellsHow
New
isContextMenuKeyEventpredicate in cell_context_menu.ts with jest tests, following the existingkeyboard_navigationhelper style. This is the base-agnostic foundation for opening the cell context menu from the keyboard; the widget wiring lands once header cells become focusable