TextBox, TextEditor, TextArea: Remove m_#33753
Open
marker-dao wants to merge 4 commits into
Open
Conversation
r-farkhutdinov
approved these changes
May 27, 2026
anna-shakhova
approved these changes
May 27, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
Pure rename refactor that drops the m_ prefix from TextBox, TextEditor, and TextArea internal modules (signaling they are no longer migrated-from-JS files), updates all import paths across the codebase, removes now-unnecessary class-methods-use-this eslint suppressions (since the migrated-file rule no longer applies), and refreshes CODEOWNERS.
Changes:
- Renamed
m_text_area.ts,m_text_box.ts,m_text_editor.ts,m_text_editor.base.tsto their non-m_equivalents and updated all@ts/.../__internal/...import paths in consumers and tests. - Removed
// eslint-disable-next-line class-methods-use-thiscomments from renamed files since the stricter "new TS files" eslint block now applies (which hasclass-methods-use-this: off). - Updated
.github/CODEOWNERSfor the renamedtext_area.ts.
Reviewed changes
Copilot reviewed 32 out of 33 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| packages/devextreme/js/__internal/ui/text_box/text_editor.ts | New wrapper file registering dxTextEditor (replaces m_text_editor.ts). |
| packages/devextreme/js/__internal/ui/text_box/text_editor.mask.ts | Updated base import paths. |
| packages/devextreme/js/__internal/ui/text_box/text_editor.mask.strategy.ts | Updated base type import. |
| packages/devextreme/js/__internal/ui/text_box/text_editor.base.ts | Removed eslint suppressions. |
| packages/devextreme/js/__internal/ui/text_box/text_box.ts | Updated base import, removed eslint suppression. |
| packages/devextreme/js/__internal/ui/text_box/texteditor_button_collection/{index,custom,button}.ts | Updated TextEditorBase type imports. |
| packages/devextreme/js/__internal/ui/text_area.ts | Updated TextBox import, removed eslint suppressions. |
| packages/devextreme/js/ui/text_box/{text_box.js,ui.text_editor.js,ui.text_editor.base.js} | Updated wrapper import paths. |
| packages/devextreme/js/ui/text_area.js | Updated wrapper import path. |
| packages/devextreme/js/__internal/ui/{collection/search_box_controller,list/modules/search,tree_view/tree_view.search,hierarchical_collection/data_adapter}.ts | Updated TextBox imports. |
| packages/devextreme/js/__internal/ui/{m_lookup,drop_down_editor/m_drop_down_editor,color_box/m_color_view,diagram/ui.diagram.toolbox,number_box/m_number_box.base}.ts | Updated TextBox/TextEditor imports. |
| packages/devextreme/js/__internal/ui/form/form.ts | Updated text_editor.base constants import. |
| packages/devextreme/js/__internal/ui/html_editor/ui/aiDialog.ts | Updated constant import path. |
| packages/devextreme/js/__internal/ui/chat/message_box/chat_text_area.ts | Updated TextArea import. |
| packages/devextreme/js/__internal/ui/tests/mock/model/text_area.ts | Updated test mock import. |
| packages/devextreme/js/__internal/grids/new/grid_core/search/utils.ts | Updated TextBoxProperties import. |
| packages/devextreme/js/__internal/grids/grid_core/ai_chat/const.ts | Updated TEXTAREA_CLASS import. |
| packages/devextreme/testing/tests/.../chatTextArea.tests.js | Updated imports. |
| packages/devextreme/testing/tests/.../aiDialog.tests.js | Updated imports. |
| packages/devextreme/testing/tests/.../form.tests.js | Updated TEXTEDITOR_INPUT_CLASS import. |
| packages/devextreme/testing/tests/.../textEditorParts/common.tests.js | Updated TextEditor import. |
| .github/CODEOWNERS | Updated path for renamed text_area.ts. |
pharret31
approved these changes
May 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.