AI Assistant: update filterValue command public types#33750
Open
anna-shakhova wants to merge 1 commit into
Open
AI Assistant: update filterValue command public types#33750anna-shakhova wants to merge 1 commit into
anna-shakhova wants to merge 1 commit into
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the public TypeScript types for the AI Assistant filterValue command in DevExtreme grids by switching from nested filter expression objects to an ID-based expression tree model, and propagates the new types through internal AI command code and wrapper re-exports.
Changes:
- Replaces
FilterExprObjwith a newFilterExprTreemodel (rootId+ flatnodes) forPredefinedCommands.filterValue.expression. - Renames filter expression public types (
*Obj→ non-Obj) and changes combined/negated expression structure to use*Idreferences. - Updates internal AI assistant filtering command typings and Angular/React/Vue wrapper type re-exports.
Reviewed changes
Copilot reviewed 7 out of 9 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| packages/devextreme/ts/dx.all.d.ts | Updates global/public grid type declarations for the new FilterExprTree-based filterValue command. |
| packages/devextreme/js/common/grids.d.ts | Updates the public devextreme/common/grids module types to expose the new filter expression tree model. |
| packages/devextreme/js/__internal/grids/grid_core/ai_assistant/commands/filtering.ts | Switches internal AI filter command typings to import the new public filter tree types. |
| packages/devextreme-vue/src/common/index.ts | Re-exports the renamed/new grid filter expression types in the Vue wrapper surface. |
| packages/devextreme-vue/src/common/grids.ts | Re-exports the renamed/new grid filter expression types from devextreme/common/grids for Vue. |
| packages/devextreme-react/src/common/index.ts | Re-exports the renamed/new grid filter expression types in the React wrapper surface. |
| packages/devextreme-react/src/common/grids.ts | Re-exports the renamed/new grid filter expression types from devextreme/common/grids for React. |
| packages/devextreme-angular/src/common/index.ts | Re-exports the renamed/new grid filter expression types in the Angular wrapper surface. |
| packages/devextreme-angular/src/common/grids/index.ts | Re-exports the renamed/new grid filter expression types from devextreme/common/grids for Angular. |
dmirgaev
approved these changes
May 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.