Skip to content

Scheduler - Migrate popup recurrence and form customization tests to isolated environment#33739

Open
bit-byte0 wants to merge 7 commits into
DevExpress:26_1from
bit-byte0:test/scheduler-migrate-popup-form-tests
Open

Scheduler - Migrate popup recurrence and form customization tests to isolated environment#33739
bit-byte0 wants to merge 7 commits into
DevExpress:26_1from
bit-byte0:test/scheduler-migrate-popup-form-tests

Conversation

@bit-byte0
Copy link
Copy Markdown
Contributor

What

Migrated popup form tests from full Scheduler to isolated createAppointmentPopup() helper

How

Replaced createScheduler() + showAppointmentPopup() with createAppointmentPopup() directly, using the POM to interact with the form. Removed duplicate tests, applied it.each where applicable

@bit-byte0 bit-byte0 self-assigned this May 27, 2026
Copilot AI review requested due to automatic review settings May 27, 2026 06:54
@bit-byte0 bit-byte0 requested a review from a team as a code owner May 27, 2026 06:54
@bit-byte0 bit-byte0 added the 26_1 label May 27, 2026
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR migrates Scheduler appointment popup recurrence and form customization tests from the full dxScheduler integration setup to an isolated createAppointmentPopup() test environment, reducing dependency on Scheduler rendering and improving test focus.

Changes:

  • Added isolated AppointmentPopup tests covering validation behavior, recurrence form state/UX, localization, and form items customization.
  • Removed corresponding validation/recurrence/customization test coverage from the Scheduler integration test suite to avoid duplication.
  • Kept Scheduler integration tests for behaviors that require Scheduler interactions (e.g., popup opening via UI interactions, toolbar behaviors, popup sizing options).

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.

File Description
packages/devextreme/js/__internal/scheduler/appointment_popup/appointment_popup.test.ts Adds/extends isolated AppointmentPopup tests for validation, recurrence form, localization, animation offset, and form item customization.
packages/devextreme/js/__internal/scheduler/appointment_popup/appointment_popup.integration.test.ts Removes tests migrated to isolated environment and keeps Scheduler-dependent integration scenarios.

Copilot AI review requested due to automatic review settings May 27, 2026 09:10
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants