Scheduler - Migrate popup recurrence and form customization tests to isolated environment#33739
Open
bit-byte0 wants to merge 7 commits into
Open
Scheduler - Migrate popup recurrence and form customization tests to isolated environment#33739bit-byte0 wants to merge 7 commits into
bit-byte0 wants to merge 7 commits into
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR migrates Scheduler appointment popup recurrence and form customization tests from the full dxScheduler integration setup to an isolated createAppointmentPopup() test environment, reducing dependency on Scheduler rendering and improving test focus.
Changes:
- Added isolated AppointmentPopup tests covering validation behavior, recurrence form state/UX, localization, and form items customization.
- Removed corresponding validation/recurrence/customization test coverage from the Scheduler integration test suite to avoid duplication.
- Kept Scheduler integration tests for behaviors that require Scheduler interactions (e.g., popup opening via UI interactions, toolbar behaviors, popup sizing options).
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
packages/devextreme/js/__internal/scheduler/appointment_popup/appointment_popup.test.ts |
Adds/extends isolated AppointmentPopup tests for validation, recurrence form, localization, animation offset, and form item customization. |
packages/devextreme/js/__internal/scheduler/appointment_popup/appointment_popup.integration.test.ts |
Removes tests migrated to isolated environment and keeps Scheduler-dependent integration scenarios. |
aleksei-semikozov
approved these changes
May 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Migrated popup form tests from full Scheduler to isolated
createAppointmentPopup()helperHow
Replaced
createScheduler()+showAppointmentPopup()withcreateAppointmentPopup()directly, using thePOMto interact with the form. Removed duplicate tests, appliedit.eachwhere applicable