Gulp: Migrate gulp test-timezones-data task#33700
Open
ajivanyandev wants to merge 1 commit into
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Migrates the legacy Gulp “test-timezones-data” verification into an Nx executor within devextreme-nx-infra-plugin, and wires a new devextreme:test:timezones target to validate DevExtreme’s bundled scheduler timezone list against Moment Timezone’s latest dataset.
Changes:
- Added a new
test-timezonesNx executor that readstimezone_list.ts, fetches Moment Timezone data, and fails on unknown identifiers. - Added Jest E2E coverage for parsing/validation helpers and executor behavior (success/failure + error scenarios).
- Registered the executor in the plugin and exposed a
test:timezonestarget inpackages/devextreme.
Reviewed changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| packages/nx-infra-plugin/src/executors/test-timezones/test-timezones.impl.ts | Implements timezone list extraction, remote fetch, and validation logic for the executor. |
| packages/nx-infra-plugin/src/executors/test-timezones/schema.ts | Declares TypeScript options for the new executor. |
| packages/nx-infra-plugin/src/executors/test-timezones/schema.json | Defines the executor’s JSON schema/options and defaults for Nx. |
| packages/nx-infra-plugin/src/executors/test-timezones/executor.ts | Re-exports the executor implementation as the Nx entrypoint. |
| packages/nx-infra-plugin/src/executors/test-timezones/executor.e2e.spec.ts | Adds Jest E2E tests for parsing/validation and executor runs. |
| packages/nx-infra-plugin/executors.json | Registers the new test-timezones executor in the plugin catalog. |
| packages/nx-infra-plugin/AGENTS.md | Documents the new executor in the “Notable executors” list. |
| packages/devextreme/project.json | Adds a test:timezones target that runs the new executor against the scheduler timezone list. |
| .github/copilot-instructions.md | Documents the new nx test:timezones devextreme command. |
Comment on lines
+1
to
+4
| export interface TestTimezonesExecutorSchema { | ||
| timezoneListFile: string; | ||
| momentTimezoneUrl: string; | ||
| } |
Comment on lines
+115
to
+117
| logger.info( | ||
| `All ${bundledTimezones.length} bundled timezones are valid according to moment-timezone data`, | ||
| ); |
Comment on lines
+1112
to
+1121
| "test:timezones": { | ||
| "executor": "devextreme-nx-infra-plugin:test-timezones", | ||
| "options": { | ||
| "timezoneListFile": "./js/__internal/scheduler/timezones/timezone_list.ts", | ||
| "momentTimezoneUrl": "https://raw.githubusercontent.com/moment/moment-timezone/develop/data/unpacked/latest.json" | ||
| }, | ||
| "inputs": [ | ||
| "{projectRoot}/js/__internal/scheduler/timezones/timezone_list.ts" | ||
| ] | ||
| }, |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.