Skip to content

PivotGrid - Fix unstable tests - QUnit - sortable.tests.js #32588

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
aleksei-semikozov wants to merge 4 commits into
base: 26_1
Choose a base branch
from
+11 −9
Draft

PivotGrid - Fix unstable tests - QUnit - sortable.tests.js #32588

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
ef102a5
PivotGrid: enable tests for horizontal dragging between lines
aleksei-semikozov Feb 16, 2026
f201fe1
PivotGrid: fix item order in sortable tests for horizontal dragging
aleksei-semikozov Feb 16, 2026
c945d12
PivotGrid: fix target index in RTL horizontal dragging test
aleksei-semikozov Feb 16, 2026
c8962fb
Merge branch '26_1' into fix/3260-pivotgrid-sortable-tests
aleksei-semikozov Feb 17, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 11 additions & 9 deletions packages/devextreme/testing/tests/DevExpress.ui.widgets.pivotGrid/sortable.tests.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -197,7 +197,7 @@ QUnit.module('sortable without containers', () => {
assert.equal($items.eq(3).text(), '4', 'item 3 text');
});

QUnit.skip('horizontal dragging between lines', function(assert) {
QUnit.test('horizontal dragging between lines', function(assert) {
createHorizontalMarkUp(HORIZONTAL_WIDTH_SMALL, true);

const $sortable = $('#sortable').dxSortableOld({
Expand Down Expand Up @@ -225,11 +225,11 @@ QUnit.module('sortable without containers', () => {
assert.equal($items.eq(1).text(), '3', 'item 1 text');
assert.equal($items.eq(2).text(), '4', 'item 2 text');
assert.equal($items.eq(3).text(), '5', 'item 3 text');
assert.equal($items.eq(4).text(), '1', 'item 4 text');
assert.equal($items.eq(5).text(), '6', 'item 5 text');
assert.equal($items.eq(4).text(), '6', 'item 4 text');
assert.equal($items.eq(5).text(), '1', 'item 5 text');
});

QUnit.skip('horizontal dragging between lines to the end of the first line', function(assert) {
QUnit.test('horizontal dragging between lines to the end of the first line', function(assert) {
createHorizontalMarkUp(HORIZONTAL_WIDTH_SMALL, true);

const $sortable = $('#sortable').dxSortableOld({
Expand Down Expand Up @@ -490,7 +490,7 @@ QUnit.module('sortable without containers', () => {
assert.ok(!changedArgs, 'changed called');
});

QUnit.skip('dragging not allowed item', function(assert) {
QUnit.test('dragging not allowed item', function(assert) {
let changedArgs;
const $sortable = $('#sortable').dxSortableOld({
itemSelector: '.test-item',
Expand All @@ -500,6 +500,8 @@ QUnit.module('sortable without containers', () => {
}
});

$('<div>').addClass('not-test-item').text('X').appendTo('.test-container');

const $item = $sortable.find('.not-test-item').eq(0);
const offset = $item.offset();

Expand Down Expand Up @@ -1768,7 +1770,7 @@ QUnit.module('Horizontal direction. RTL', {
assert.strictEqual(this.sortable.option('onChanged').lastCall.args[0].targetIndex, 2);
});

QUnit.skip('horizontal dragging between lines', function(assert) {
QUnit.test('horizontal dragging between lines', function(assert) {
createHorizontalMarkUp(HORIZONTAL_WIDTH_SMALL, true);

const $sortable = this.createSortable({});
Expand All @@ -1790,11 +1792,11 @@ QUnit.module('Horizontal direction. RTL', {
assert.equal($items.eq(1).text(), '3', 'item 1 text');
assert.equal($items.eq(2).text(), '4', 'item 2 text');
assert.equal($items.eq(3).text(), '5', 'item 3 text');
assert.equal($items.eq(4).text(), '1', 'item 4 text');
assert.equal($items.eq(5).text(), '6', 'item 5 text');
assert.equal($items.eq(4).text(), '6', 'item 4 text');
assert.equal($items.eq(5).text(), '1', 'item 5 text');

assert.strictEqual(this.sortable.option('onChanged').lastCall.args[0].sourceIndex, 0);
assert.strictEqual(this.sortable.option('onChanged').lastCall.args[0].targetIndex, 5);
assert.strictEqual(this.sortable.option('onChanged').lastCall.args[0].targetIndex, 6);
});

QUnit.test('drag to the end of the container', function(assert) {
Expand Down
Loading