Fix: Vitest, the "window.getComputedStyle" error is not defined when running tests #31987
+39
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes a Vitest compatibility issue where window.getComputedStyle errors are not handled gracefully in the readThemeMarker function. The fix adds a catch block to return null when getComputedStyle throws an error, preventing test failures in environments like Vitest where this method may not be fully implemented.
Key Changes:
- Added error handling to
readThemeMarker()function in themes.ts to catch and handlegetComputedStyleerrors - Added test coverage for the new error handling behavior
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| packages/devextreme/js/__internal/ui/themes.ts | Added catch block to readThemeMarker() to gracefully handle getComputedStyle errors by returning null |
| packages/devextreme/testing/tests/DevExpress.ui/themes.tests.js | Added two new tests to verify error handling when getComputedStyle throws errors |
…ivanyandev/DevExtreme into fix/vitest-get-computed-style
VasilyStrelyaev
approved these changes
Dec 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.