fix(windows): use wide-char API for non-ASCII path support#386
Open
jjserenity wants to merge 1 commit into
Open
fix(windows): use wide-char API for non-ASCII path support#386jjserenity wants to merge 1 commit into
jjserenity wants to merge 1 commit into
Conversation
Replace ANSI Windows APIs (FindFirstFileA, CreateFileA, etc.) with wide-char (W) counterparts. Add UTF-8/UTF-16 conversion helpers. Fix stat() calls in discover pipeline to use _wstat64. Fixes DeusData#357
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #357
Replace ANSI Windows APIs with their wide-char (W) counterparts to support non-ASCII UTF-8 paths (CJK, Cyrillic, Turkish, etc.) on Windows.
Changes
src/foundation/win_utf8.h: UTF-8 ↔ UTF-16 conversion helpers (cbm_utf8_to_wide,cbm_wide_to_utf8)src/foundation/compat_fs.c:cbm_opendir/cbm_readdir:FindFirstFileA/FindNextFileA→FindFirstFileW/FindNextFileWcbm_mkdir_p:_mkdir→_wmkdircbm_unlink:_unlink→_wunlinkcbm_rmdir:_rmdir→_wrmdirsrc/foundation/platform.c:cbm_mmap_read:CreateFileA/CreateFileMappingA→CreateFileW/CreateFileMappingWcbm_file_exists/cbm_is_dir:GetFileAttributesA→GetFileAttributesWcbm_file_size:GetFileAttributesExA→GetFileAttributesExWsrc/discover/discover.c:safe_stat+try_load_nested_gitignore+cbm_discover:stat()→_wstat64()via newwide_stat()helperScope
Windows only — all changes are guarded by
#ifdef _WIN32. POSIX paths untouched. Zero behavioral change for macOS/Linux.Tested
-Wall -Wextra -Werror -fsyntax-only)