Skip to content

fix(mcp): cap search_graph default limit to 200 (was 500K) #231

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
amitmynd wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(mcp): cap search_graph default limit to 200 (was 500K) #231

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions src/mcp/mcp.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -290,7 +290,7 @@ static const tool_def_t TOOLS[] = {
"that score well on ALL keywords. Requires moderate/full index mode. Results appear in the "
"'semantic_results' field (separate from 'results').\"},\"limit\":{\"type\":"
"\"integer\",\"description\":\"Max results. Default: "
"unlimited\"},\"offset\":{\"type\":\"integer\",\"default\":0}},\"required\":[\"project\"]}"},
"200\"},\"offset\":{\"type\":\"integer\",\"default\":0}},\"required\":[\"project\"]}"},

{"query_graph",
"Execute a Cypher query against the knowledge graph for complex multi-hop patterns, "
Expand Down Expand Up @@ -1341,7 +1341,8 @@ static char *handle_search_graph(cbm_mcp_server_t *srv, const char *args) {
char *relationship = cbm_mcp_get_string_arg(args, "relationship");
bool exclude_entry_points = cbm_mcp_get_bool_arg(args, "exclude_entry_points");
bool include_connected = cbm_mcp_get_bool_arg(args, "include_connected");
int limit = cbm_mcp_get_int_arg(args, "limit", MCP_HALF_SEC_US);
enum { SEARCH_DEFAULT_LIMIT = 200 };
int limit = cbm_mcp_get_int_arg(args, "limit", SEARCH_DEFAULT_LIMIT);
int offset = cbm_mcp_get_int_arg(args, "offset", 0);
int min_degree = cbm_mcp_get_int_arg(args, "min_degree", CBM_NOT_FOUND);
int max_degree = cbm_mcp_get_int_arg(args, "max_degree", CBM_NOT_FOUND);
Expand Down
3 changes: 2 additions & 1 deletion src/store/store.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2301,7 +2301,8 @@ int cbm_store_search(cbm_store_t *s, const cbm_search_params_t *params, cbm_sear
snprintf(count_sql, sizeof(count_sql), "SELECT COUNT(*) FROM (%s)", sql);

/* Add ORDER BY + LIMIT */
int limit = params->limit > 0 ? params->limit : ST_HALF_SEC;
enum { ST_DEFAULT_SEARCH_LIMIT = 200 };
int limit = params->limit > 0 ? params->limit : ST_DEFAULT_SEARCH_LIMIT;
int offset = params->offset;
const char *name_col = has_degree_filter ? "name" : "n.name";
char order_limit[CBM_SZ_128];
Expand Down